| Message ID | 20170623150525.7014-1-venture@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, Jun 23, 2017 at 08:05:25AM -0700, Patrick Venture wrote: > Reduce the fan_tach period such that the fan controller uses a shorter > period to measure the rpm. > > Testing: Tested on an ast2400 sitting on a quanta-q71l. > > Signed-off-by: Patrick Venture <venture@google.com> Please provide change logs, and keep version numbers consistent for a series even if one patch doesn't change. Now I'll have to go back, find the flurry of older versions, and try to find out what changed and why. This takes time which I don't have. I'll probably only get to this after the next commit window, sorry. Guenter > --- > drivers/hwmon/aspeed-pwm-tacho.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c > index 86e2ea8287a7..b2ab5612d8a4 100644 > --- a/drivers/hwmon/aspeed-pwm-tacho.c > +++ b/drivers/hwmon/aspeed-pwm-tacho.c > @@ -160,7 +160,7 @@ > * 11: reserved. > */ > #define M_TACH_MODE 0x02 /* 10b */ > -#define M_TACH_UNIT 0x1000 > +#define M_TACH_UNIT 0x00c0 > #define INIT_FAN_CTRL 0xFF > > struct aspeed_pwm_tacho_data { > -- > 2.13.1.611.g7e3b11ae1-goog > -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 23, 2017 at 12:33:47PM -0700, Patrick Venture wrote: > I changed the commit message. Since you said you never received this patch, > it was prudent to resend it. However, since I had sent it and you said you > didn't receive it, I assumed it was being merged with the previous patch > that had been before using a patch-set was required. So I modified the > commit message so I could bump the version so you'd likely see it this > time; whereas before it was getting clumped with the previous fodder. > > I was deliberately trying to be helpful. I didn't know you needed the > history and couldn't just use the latest patch version. > 2/2 does not have a change log either. > Patrick > > On Jun 23, 2017 8:29 AM, "Guenter Roeck" <linux@roeck-us.net> wrote: > > > On Fri, Jun 23, 2017 at 08:05:25AM -0700, Patrick Venture wrote: > > > Reduce the fan_tach period such that the fan controller uses a shorter > > > period to measure the rpm. > > > > > > Testing: Tested on an ast2400 sitting on a quanta-q71l. > > > > > > Signed-off-by: Patrick Venture <venture@google.com> > > > > Please provide change logs, and keep version numbers consistent > > for a series even if one patch doesn't change. > > > > Now I'll have to go back, find the flurry of older versions, and try > > to find out what changed and why. This takes time which I don't have. > > I'll probably only get to this after the next commit window, sorry. > > > > Guenter > > > > > --- > > > drivers/hwmon/aspeed-pwm-tacho.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/hwmon/aspeed-pwm-tacho.c > > b/drivers/hwmon/aspeed-pwm-tacho.c > > > index 86e2ea8287a7..b2ab5612d8a4 100644 > > > --- a/drivers/hwmon/aspeed-pwm-tacho.c > > > +++ b/drivers/hwmon/aspeed-pwm-tacho.c > > > @@ -160,7 +160,7 @@ > > > * 11: reserved. > > > */ > > > #define M_TACH_MODE 0x02 /* 10b */ > > > -#define M_TACH_UNIT 0x1000 > > > +#define M_TACH_UNIT 0x00c0 > > > #define INIT_FAN_CTRL 0xFF > > > > > > struct aspeed_pwm_tacho_data { > > > -- > > > 2.13.1.611.g7e3b11ae1-goog > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c index 86e2ea8287a7..b2ab5612d8a4 100644 --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -160,7 +160,7 @@ * 11: reserved. */ #define M_TACH_MODE 0x02 /* 10b */ -#define M_TACH_UNIT 0x1000 +#define M_TACH_UNIT 0x00c0 #define INIT_FAN_CTRL 0xFF struct aspeed_pwm_tacho_data {
Reduce the fan_tach period such that the fan controller uses a shorter period to measure the rpm. Testing: Tested on an ast2400 sitting on a quanta-q71l. Signed-off-by: Patrick Venture <venture@google.com> --- drivers/hwmon/aspeed-pwm-tacho.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)