| Message ID | 1498451432-14165-1-git-send-email-hui.wang@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 26 Jun 2017 06:30:32 +0200, Hui Wang wrote: > > We have a Lenovo machine with the codec ALC294 on it, without the > patch, the Node 0x0b is regarded as the loopback mixer, but the Node > 0x0b in this codec is "Vendor Defined Widget" instead of the audio > mixer, please see the log below: > > Node 0x0b [Vendor Defined Widget] wcaps 0xf00000: Mono > Control: name="Beep Playback Volume", index=0, device=0 > ControlAmp: chs=3, dir=In, idx=4, ofs=0 > Control: name="Beep Playback Switch", index=0, device=0 > ControlAmp: chs=3, dir=In, idx=4, ofs=0 > > And I have consulted with Realtek, so far the ALC234/274/294 all don't > have loopback mixer. > > Cc: Kailang Yang <kailang@realtek.com> > Signed-off-by: Hui Wang <hui.wang@canonical.com> Applied, thanks. Takashi > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index c4a1b49..bc00a37 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -6696,6 +6696,7 @@ static int patch_alc269(struct hda_codec *codec) > case 0x10ec0274: > case 0x10ec0294: > spec->codec_variant = ALC269_TYPE_ALC294; > + spec->gen.mixer_nid = 0; /* ALC2x4 does not have any loopback mixer path */ > alc_update_coef_idx(codec, 0x6b, 0x0018, (1<<4) | (1<<3)); /* UAJ MIC Vref control by verb */ > break; > case 0x10ec0700: > -- > 2.7.4 >
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c4a1b49..bc00a37 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6696,6 +6696,7 @@ static int patch_alc269(struct hda_codec *codec) case 0x10ec0274: case 0x10ec0294: spec->codec_variant = ALC269_TYPE_ALC294; + spec->gen.mixer_nid = 0; /* ALC2x4 does not have any loopback mixer path */ alc_update_coef_idx(codec, 0x6b, 0x0018, (1<<4) | (1<<3)); /* UAJ MIC Vref control by verb */ break; case 0x10ec0700:
We have a Lenovo machine with the codec ALC294 on it, without the patch, the Node 0x0b is regarded as the loopback mixer, but the Node 0x0b in this codec is "Vendor Defined Widget" instead of the audio mixer, please see the log below: Node 0x0b [Vendor Defined Widget] wcaps 0xf00000: Mono Control: name="Beep Playback Volume", index=0, device=0 ControlAmp: chs=3, dir=In, idx=4, ofs=0 Control: name="Beep Playback Switch", index=0, device=0 ControlAmp: chs=3, dir=In, idx=4, ofs=0 And I have consulted with Realtek, so far the ALC234/274/294 all don't have loopback mixer. Cc: Kailang Yang <kailang@realtek.com> Signed-off-by: Hui Wang <hui.wang@canonical.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)