| Message ID | 20170626082626.797-1-benjamin.tissoires@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Jun 26 2017 or thereabouts, Christopher Bachner wrote: > Hello, > > I am assuming that if the inertouch message is not showing up in dmesg, > then it is working. Is that a correct assumption? > > Either way I also attached my dmesg. > > I am not sure, though, why the scroll mode still freezes if I move the my > fingers quickly on the touchpad while also using the trackpoint. Is that > maybe a future fix and this change is just the foundation for it? Overall > the usage of the trackpoint is better now for sure. Sadly, you are also hit by: [ 6.355378] i801_smbus 0000:00:1f.4: BIOS is accessing SMBus registers [ 6.355380] i801_smbus 0000:00:1f.4: Driver SMBus register access inhibited Which disables entirely the RMI4 over SMBus module. And then we can not probe for it, meaning you are stuck with the PS/2 crappy mode. We are aware of this bug and we'll try to fix that. I think the test you provides are valid (the patch works as expected), but a different bug prevents rmi-smbus to fully initialize the touchpad :( Cheers, Benjamin > > > (Resending again without attachment since the linux-kernel@vger.kernel.org > and linux-input@vger.kernel.org don't accept attachments) > > > --- > Thanks, > > Christopher Bachner > > --- > Thanks, > > Christopher Bachner > > On Mon, Jun 26, 2017 at 8:12 AM, Christopher Bachner < > b.christopher.92@gmail.com> wrote: > > > Hello, > > > > I am assuming that if the inertouch message is not showing up in dmesg, > > then it is working. Is that a correct assumption? > > > > Either way I also attached my dmesg. > > > > I am not sure, though, why the scroll mode still freezes if I move the my > > fingers quickly on the touchpad while also using the trackpoint. Is that > > maybe a future fix and this change is just the foundation for it? Overall > > the usage of the trackpoint is better now for sure. > > > > > > > > --- > > Thanks, > > > > Christopher Bachner > > > > On Mon, Jun 26, 2017 at 1:26 AM, Benjamin Tissoires < > > benjamin.tissoires@redhat.com> wrote: > > > >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > >> > >> --- > >> > >> Hi Christopher, > >> > >> Could you please test this patch without appending synaptics_intertouch=1 > >> to the boot command line? If this still works, we will have the RMI4 over > >> SMBus by default for your laptop. > >> > >> Cheers, > >> Benjamin > >> > >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > >> --- > >> drivers/input/mouse/synaptics.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/input/mouse/synaptics.c > >> b/drivers/input/mouse/synaptics.c > >> index f4fbe1a..a8fb26bc 100644 > >> --- a/drivers/input/mouse/synaptics.c > >> +++ b/drivers/input/mouse/synaptics.c > >> @@ -173,6 +173,7 @@ static const char * const smbus_pnp_ids[] = { > >> "LEN0046", /* X250 */ > >> "LEN004a", /* W541 */ > >> "LEN200f", /* T450s */ > >> + "LEN2016", /* T460 20FN */ > >> NULL > >> }; > >> > >> -- > >> 2.9.4 > >> > >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Jun 26 2017 or thereabouts, Benjamin Tissoires wrote: > On Jun 26 2017 or thereabouts, Christopher Bachner wrote: > > Hello, > > > > I am assuming that if the inertouch message is not showing up in dmesg, > > then it is working. Is that a correct assumption? > > > > Either way I also attached my dmesg. > > > > I am not sure, though, why the scroll mode still freezes if I move the my > > fingers quickly on the touchpad while also using the trackpoint. Is that > > maybe a future fix and this change is just the foundation for it? Overall > > the usage of the trackpoint is better now for sure. > > Sadly, you are also hit by: > [ 6.355378] i801_smbus 0000:00:1f.4: BIOS is accessing SMBus registers > [ 6.355380] i801_smbus 0000:00:1f.4: Driver SMBus register access inhibited > > Which disables entirely the RMI4 over SMBus module. And then we can not > probe for it, meaning you are stuck with the PS/2 crappy mode. > > We are aware of this bug and we'll try to fix that. I think the test you > provides are valid (the patch works as expected), but a different bug > prevents rmi-smbus to fully initialize the touchpad :( Could you try applying Lyude's patch: http://patchwork.ozlabs.org/patch/780865/ (on top of mine, of course). In the dmesg, you should see a Synaptics TMXXXX device appearing after trying to set up the SMBus companion. Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index f4fbe1a..a8fb26bc 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -173,6 +173,7 @@ static const char * const smbus_pnp_ids[] = { "LEN0046", /* X250 */ "LEN004a", /* W541 */ "LEN200f", /* T450s */ + "LEN2016", /* T460 20FN */ NULL };