Message ID | 1498601249-8372-1-git-send-email-peter.oh@bowerswilkins.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 3cb57df37bf3c87c7bbd2bd6f94d9d48c1c8e2ae |
Delegated to: | Kalle Valo |
Headers | show |
On 28-06-17 00:07, peter.oh@bowerswilkins.com wrote: > From: Peter Oh <peter.oh@bowerswilkins.com> > > Update Public Action field values as updated in IEEE Std 802.11-2016, > so that modules/drivers can refer it. Hi Peter, I am pretty sure there are a lot of other definitions in the 802.11 spec that are not in a linux header file. So are you planning on submitting driver patches using the added definitions. Stuff is mostly added as needed. Regards, Arend > Signed-off-by: Peter Oh <peter.oh@bowerswilkins.com> > --- > include/linux/ieee80211.h | 35 ++++++++++++++++++++++++++++++++++- > 1 file changed, 34 insertions(+), 1 deletion(-)
On 06/28/2017 01:16 PM, Arend van Spriel wrote: > On 28-06-17 00:07, peter.oh@bowerswilkins.com wrote: >> From: Peter Oh <peter.oh@bowerswilkins.com> >> >> Update Public Action field values as updated in IEEE Std 802.11-2016, >> so that modules/drivers can refer it. > Hi Peter, > > I am pretty sure there are a lot of other definitions in the 802.11 spec > that are not in a linux header file. So are you planning on submitting > driver patches using the added definitions. Stuff is mostly added as needed. I have extra patches that uses the new values, but doubt if it's fit to be upstream. > Regards, > Arend
On Wed, 2017-06-28 at 13:24 -0700, Peter Oh wrote: > > On 06/28/2017 01:16 PM, Arend van Spriel wrote: > > On 28-06-17 00:07, peter.oh@bowerswilkins.com wrote: > > > From: Peter Oh <peter.oh@bowerswilkins.com> > > > > > > Update Public Action field values as updated in IEEE Std 802.11- > > > 2016, > > > so that modules/drivers can refer it. > > > > Hi Peter, > > > > I am pretty sure there are a lot of other definitions in the 802.11 > > spec > > that are not in a linux header file. So are you planning on > > submitting > > driver patches using the added definitions. Stuff is mostly added > > as needed. I think that's mostly laziness though :-) I'm perfectly happy to have all these values in even if we don't use them now - they're not going to change by not using. > I have extra patches that uses the new values, but doubt if it's fit > to be upstream. I guess you can try :) johannes
On Tue, 2017-06-27 at 15:07 -0700, peter.oh@bowerswilkins.com wrote: > From: Peter Oh <peter.oh@bowerswilkins.com> > > Update Public Action field values as updated in IEEE Std 802.11-2016, > so that modules/drivers can refer it. > > Signed-off-by: Peter Oh <peter.oh@bowerswilkins.com> Reviewed-by: Johannes Berg <johannes@sipsolutions.net> Kalle, it looks like this is the only patch I'm willing to pick up before I go, so I figured you can just throw it into your tree, and will assign it to you in patchwork. johannes
Johannes Berg <johannes@sipsolutions.net> writes: > On Tue, 2017-06-27 at 15:07 -0700, peter.oh@bowerswilkins.com wrote: >> From: Peter Oh <peter.oh@bowerswilkins.com> >> >> Update Public Action field values as updated in IEEE Std 802.11-2016, >> so that modules/drivers can refer it. >> >> Signed-off-by: Peter Oh <peter.oh@bowerswilkins.com> > > Reviewed-by: Johannes Berg <johannes@sipsolutions.net> > > Kalle, it looks like this is the only patch I'm willing to pick up > before I go, so I figured you can just throw it into your tree, and > will assign it to you in patchwork. Sure, I'll take it. Enjoy your sabbatical!
Peter Oh <peter.oh@bowerswilkins.com> wrote: > From: Peter Oh <peter.oh@bowerswilkins.com> > > Update Public Action field values as updated in IEEE Std 802.11-2016, > so that modules/drivers can refer it. > > Signed-off-by: Peter Oh <peter.oh@bowerswilkins.com> > Reviewed-by: Johannes Berg <johannes@sipsolutions.net> Patch applied to wireless-drivers-next.git, thanks. 3cb57df37bf3 ieee80211: update public action codes
diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h index 6903335..91a1145 100644 --- a/include/linux/ieee80211.h +++ b/include/linux/ieee80211.h @@ -2113,10 +2113,43 @@ enum ieee80211_key_len { #define PMK_MAX_LEN 48 -/* Public action codes */ +/* Public action codes (IEEE Std 802.11-2016, 9.6.8.1, Table 9-307) */ enum ieee80211_pub_actioncode { + WLAN_PUB_ACTION_20_40_BSS_COEX = 0, + WLAN_PUB_ACTION_DSE_ENABLEMENT = 1, + WLAN_PUB_ACTION_DSE_DEENABLEMENT = 2, + WLAN_PUB_ACTION_DSE_REG_LOC_ANN = 3, WLAN_PUB_ACTION_EXT_CHANSW_ANN = 4, + WLAN_PUB_ACTION_DSE_MSMT_REQ = 5, + WLAN_PUB_ACTION_DSE_MSMT_RESP = 6, + WLAN_PUB_ACTION_MSMT_PILOT = 7, + WLAN_PUB_ACTION_DSE_PC = 8, + WLAN_PUB_ACTION_VENDOR_SPECIFIC = 9, + WLAN_PUB_ACTION_GAS_INITIAL_REQ = 10, + WLAN_PUB_ACTION_GAS_INITIAL_RESP = 11, + WLAN_PUB_ACTION_GAS_COMEBACK_REQ = 12, + WLAN_PUB_ACTION_GAS_COMEBACK_RESP = 13, WLAN_PUB_ACTION_TDLS_DISCOVER_RES = 14, + WLAN_PUB_ACTION_LOC_TRACK_NOTI = 15, + WLAN_PUB_ACTION_QAB_REQUEST_FRAME = 16, + WLAN_PUB_ACTION_QAB_RESPONSE_FRAME = 17, + WLAN_PUB_ACTION_QMF_POLICY = 18, + WLAN_PUB_ACTION_QMF_POLICY_CHANGE = 19, + WLAN_PUB_ACTION_QLOAD_REQUEST = 20, + WLAN_PUB_ACTION_QLOAD_REPORT = 21, + WLAN_PUB_ACTION_HCCA_TXOP_ADVERT = 22, + WLAN_PUB_ACTION_HCCA_TXOP_RESPONSE = 23, + WLAN_PUB_ACTION_PUBLIC_KEY = 24, + WLAN_PUB_ACTION_CHANNEL_AVAIL_QUERY = 25, + WLAN_PUB_ACTION_CHANNEL_SCHEDULE_MGMT = 26, + WLAN_PUB_ACTION_CONTACT_VERI_SIGNAL = 27, + WLAN_PUB_ACTION_GDD_ENABLEMENT_REQ = 28, + WLAN_PUB_ACTION_GDD_ENABLEMENT_RESP = 29, + WLAN_PUB_ACTION_NETWORK_CHANNEL_CONTROL = 30, + WLAN_PUB_ACTION_WHITE_SPACE_MAP_ANN = 31, + WLAN_PUB_ACTION_FTM_REQUEST = 32, + WLAN_PUB_ACTION_FTM = 33, + WLAN_PUB_ACTION_FILS_DISCOVERY = 34, }; /* TDLS action codes */