[v2] rtlwifi: Replace hardcode value with macro

Message ID	20170622120004.GA5783@symbol-HP-ZBook-15 (mailing list archive)
State	Changes Requested
Delegated to:	Kalle Valo
Headers	show Return-Path: <linux-wireless-owner@kernel.org> Date: Thu, 22 Jun 2017 17:30:04 +0530 From: Souptick Joarder <jrdr.linux@gmail.com> To: Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn Cc: linux-wireless@vger.kernel.org Subject: [PATCH v2] rtlwifi: Replace hardcode value with macro Message-ID: <20170622120004.GA5783@symbol-HP-ZBook-15> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk

Message ID

20170622120004.GA5783@symbol-HP-ZBook-15 (mailing list archive)

State

Changes Requested

Delegated to:

Kalle Valo

Headers

Date: Thu, 22 Jun 2017 17:30:04 +0530
From: Souptick Joarder <jrdr.linux@gmail.com>
To: Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH v2] rtlwifi: Replace hardcode value with macro
Message-ID: <20170622120004.GA5783@symbol-HP-ZBook-15>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Commit Message

Souptick Joarder June 22, 2017, noon UTC

In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
and hw->max_rate_tries are replaced by macro.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
Changes in v2:
   - Signed-off was missing in previous one.

 drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
 drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

--
1.9.1

Comments

Larry Finger June 22, 2017, 1:35 p.m. UTC | #1

On 06/22/2017 07:00 AM, Souptick Joarder wrote:
> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
> and hw->max_rate_tries are replaced by macro.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> Changes in v2:
>     - Signed-off was missing in previous one.

This patch includes a comment that is not needed, but it is OK.

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Larry

> 
>   drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
>   drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
>   2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index bdc3791..f45d093 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
>   	hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
> 
>   	/* TODO: Correct this value for our hw */
> -	/* TODO: define these hard code value */
> -	hw->max_listen_interval = 10;
> -	hw->max_rate_tries = 4;
> +	/* defined these hard code values */
> +	hw->max_listen_interval = MAX_LISTEN_INTERVAL;
> +	hw->max_rate_tries = MAX_RATE_TRIES;
>   	/* hw->max_rates = 1; */
>   	hw->sta_data_size = sizeof(struct rtl_sta_info);
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.h b/drivers/net/wireless/realtek/rtlwifi/base.h
> index 02ff0c5..d03e198 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.h
> @@ -65,6 +65,8 @@ enum ap_peer {
>   #define FRAME_OFFSET_ADDRESS3		16
>   #define FRAME_OFFSET_SEQUENCE		22
>   #define FRAME_OFFSET_ADDRESS4		24
> +#define MAX_LISTEN_INTERVAL             10
> +#define MAX_RATE_TRIES                  4
> 
>   #define SET_80211_HDR_FRAME_CONTROL(_hdr, _val)		\
>   	WRITEEF2BYTE(_hdr, _val)
> --
> 1.9.1
> 
>

Souptick Joarder June 28, 2017, 4:29 a.m. UTC | #2

Hi Larry,

On Thu, Jun 22, 2017 at 7:05 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> On 06/22/2017 07:00 AM, Souptick Joarder wrote:
>>
>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
>> and hw->max_rate_tries are replaced by macro.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> ---
>> Changes in v2:
>>     - Signed-off was missing in previous one.
>
>
> This patch includes a comment that is not needed, but it is OK.
>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> Larry

Any further review is required for this patch or it will be merged to
maintainer tree ?

>
>
>>
>>   drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
>>   drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
>>   2 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c
>> b/drivers/net/wireless/realtek/rtlwifi/base.c
>> index bdc3791..f45d093 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
>> @@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw
>> *hw)
>>         hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
>>
>>         /* TODO: Correct this value for our hw */
>> -       /* TODO: define these hard code value */
>> -       hw->max_listen_interval = 10;
>> -       hw->max_rate_tries = 4;
>> +       /* defined these hard code values */
>> +       hw->max_listen_interval = MAX_LISTEN_INTERVAL;
>> +       hw->max_rate_tries = MAX_RATE_TRIES;
>>         /* hw->max_rates = 1; */
>>         hw->sta_data_size = sizeof(struct rtl_sta_info);
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.h
>> b/drivers/net/wireless/realtek/rtlwifi/base.h
>> index 02ff0c5..d03e198 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.h
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.h
>> @@ -65,6 +65,8 @@ enum ap_peer {
>>   #define FRAME_OFFSET_ADDRESS3         16
>>   #define FRAME_OFFSET_SEQUENCE         22
>>   #define FRAME_OFFSET_ADDRESS4         24
>> +#define MAX_LISTEN_INTERVAL             10
>> +#define MAX_RATE_TRIES                  4
>>
>>   #define SET_80211_HDR_FRAME_CONTROL(_hdr, _val)               \
>>         WRITEEF2BYTE(_hdr, _val)
>> --
>> 1.9.1
>>
>>
>

-Souptick

Kalle Valo June 28, 2017, 4:17 p.m. UTC | #3

Souptick Joarder <jrdr.linux@gmail.com> writes:

> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
> and hw->max_rate_tries are replaced by macro.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> Changes in v2:
>    - Signed-off was missing in previous one.
>
>  drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
>  drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
>  2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index bdc3791..f45d093 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
>  	hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
>
>  	/* TODO: Correct this value for our hw */
> -	/* TODO: define these hard code value */
> -	hw->max_listen_interval = 10;
> -	hw->max_rate_tries = 4;
> +	/* defined these hard code values */
> +	hw->max_listen_interval = MAX_LISTEN_INTERVAL;
> +	hw->max_rate_tries = MAX_RATE_TRIES;

Like Larry said, the comment does not make any sense. Please remove it
and send v3.

Souptick Joarder June 29, 2017, 4:13 a.m. UTC | #4

Hi Kalle,

On Wed, Jun 28, 2017 at 9:47 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Souptick Joarder <jrdr.linux@gmail.com> writes:
>
>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
>> and hw->max_rate_tries are replaced by macro.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>> ---
>> Changes in v2:
>>    - Signed-off was missing in previous one.

As Signed-off was missing in first patch, so I send v2 with change
logs mentioned the same.
Just for clarification, shall I replace the comment mentioned in
change log with "no change"?

>>
>>  drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---
>>  drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
>>  2 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
>> index bdc3791..f45d093 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
>> @@ -422,9 +422,9 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
>>       hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
>>
>>       /* TODO: Correct this value for our hw */
>> -     /* TODO: define these hard code value */
>> -     hw->max_listen_interval = 10;
>> -     hw->max_rate_tries = 4;
>> +     /* defined these hard code values */
>> +     hw->max_listen_interval = MAX_LISTEN_INTERVAL;
>> +     hw->max_rate_tries = MAX_RATE_TRIES;
>
> Like Larry said, the comment does not make any sense. Please remove it
> and send v3.
>
> --
> Kalle Valo

Souptick

diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
index bdc3791..f45d093 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.c
+++ b/drivers/net/wireless/realtek/rtlwifi/base.c
@@ -422,9 +422,9 @@  static void _rtl_init_mac80211(struct ieee80211_hw *hw)
 	hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;

 	/* TODO: Correct this value for our hw */
-	/* TODO: define these hard code value */
-	hw->max_listen_interval = 10;
-	hw->max_rate_tries = 4;
+	/* defined these hard code values */
+	hw->max_listen_interval = MAX_LISTEN_INTERVAL;
+	hw->max_rate_tries = MAX_RATE_TRIES;
 	/* hw->max_rates = 1; */
 	hw->sta_data_size = sizeof(struct rtl_sta_info);

diff --git a/drivers/net/wireless/realtek/rtlwifi/base.h b/drivers/net/wireless/realtek/rtlwifi/base.h
index 02ff0c5..d03e198 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.h
+++ b/drivers/net/wireless/realtek/rtlwifi/base.h
@@ -65,6 +65,8 @@  enum ap_peer {
 #define FRAME_OFFSET_ADDRESS3		16
 #define FRAME_OFFSET_SEQUENCE		22
 #define FRAME_OFFSET_ADDRESS4		24
+#define MAX_LISTEN_INTERVAL             10
+#define MAX_RATE_TRIES                  4

 #define SET_80211_HDR_FRAME_CONTROL(_hdr, _val)		\
 	WRITEEF2BYTE(_hdr, _val)

[v2] rtlwifi: Replace hardcode value with macro

Commit Message

Comments

Patch