| Message ID | 1498557807-10810-2-git-send-email-al1img@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jun 27, 2017 at 01:03:17PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov <oleksandr_grytsov@epam.com> > > Add libxl_device_vdispl and libxl_vdisplinfo to libxl_types.idl > Add VDISPL to libxl__device_kind enumerator > > Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> > --- > tools/libxl/libxl_types.idl | 38 +++++++++++++++++++++++++++++++++++- > tools/libxl/libxl_types_internal.idl | 1 + > 2 files changed, 38 insertions(+), 1 deletion(-) > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > index 2204425..25563cf 100644 > --- a/tools/libxl/libxl_types.idl > +++ b/tools/libxl/libxl_types.idl > @@ -755,7 +755,21 @@ libxl_device_vtpm = Struct("device_vtpm", [ > ("backend_domname", string), > ("devid", libxl_devid), > ("uuid", libxl_uuid), > -]) > + ]) > + > +libxl_connector_param = Struct("connector_param", [ > + ("id", string), > + ("width", uint32), > + ("height", uint32) > + ]) > + > +libxl_device_vdispl = Struct("device_vdispl", [ > + ("backend_domid", libxl_domid), > + ("backend_domname", string), > + ("devid", libxl_devid), > + ("be_alloc", bool), After reading the doc -- use "allocator" for this field?
Hi Wei, Thanks for the review. This field is already defined in the display protocol. To avoid misunderstanding I prefer to use same name in libxl as well. On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu <wei.liu2@citrix.com> wrote: > On Tue, Jun 27, 2017 at 01:03:17PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov <oleksandr_grytsov@epam.com> >> >> Add libxl_device_vdispl and libxl_vdisplinfo to libxl_types.idl >> Add VDISPL to libxl__device_kind enumerator >> >> Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> >> --- >> tools/libxl/libxl_types.idl | 38 +++++++++++++++++++++++++++++++++++- >> tools/libxl/libxl_types_internal.idl | 1 + >> 2 files changed, 38 insertions(+), 1 deletion(-) >> >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl >> index 2204425..25563cf 100644 >> --- a/tools/libxl/libxl_types.idl >> +++ b/tools/libxl/libxl_types.idl >> @@ -755,7 +755,21 @@ libxl_device_vtpm = Struct("device_vtpm", [ >> ("backend_domname", string), >> ("devid", libxl_devid), >> ("uuid", libxl_uuid), >> -]) >> + ]) >> + >> +libxl_connector_param = Struct("connector_param", [ >> + ("id", string), >> + ("width", uint32), >> + ("height", uint32) >> + ]) >> + >> +libxl_device_vdispl = Struct("device_vdispl", [ >> + ("backend_domid", libxl_domid), >> + ("backend_domname", string), >> + ("devid", libxl_devid), >> + ("be_alloc", bool), > > After reading the doc -- use "allocator" for this field?
On Fri, Jun 30, 2017 at 01:36:46PM +0300, Oleksandr Grytsov wrote: > Hi Wei, > > Thanks for the review. > > This field is already defined in the display protocol. > To avoid misunderstanding I prefer to use same name in libxl > as well. > > Never mind then. Keep it as-is.
diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index 2204425..25563cf 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -755,7 +755,21 @@ libxl_device_vtpm = Struct("device_vtpm", [ ("backend_domname", string), ("devid", libxl_devid), ("uuid", libxl_uuid), -]) + ]) + +libxl_connector_param = Struct("connector_param", [ + ("id", string), + ("width", uint32), + ("height", uint32) + ]) + +libxl_device_vdispl = Struct("device_vdispl", [ + ("backend_domid", libxl_domid), + ("backend_domname", string), + ("devid", libxl_devid), + ("be_alloc", bool), + ("connectors", Array(libxl_connector_param, "num_connectors")) + ]) libxl_device_p9 = Struct("device_p9", [ ("backend_domid", libxl_domid), @@ -791,6 +805,7 @@ libxl_domain_config = Struct("domain_config", [ ("vkbs", Array(libxl_device_vkb, "num_vkbs")), ("vtpms", Array(libxl_device_vtpm, "num_vtpms")), ("p9", Array(libxl_device_p9, "num_p9s")), + ("vdispls", Array(libxl_device_vdispl, "num_vdispls")), # a channel manifests as a console with a name, # see docs/misc/channels.txt ("channels", Array(libxl_device_channel, "num_channels")), @@ -887,6 +902,27 @@ libxl_physinfo = Struct("physinfo", [ ("cap_hvm_directio", bool), ], dir=DIR_OUT) +libxl_connectorinfo = Struct("connectorinfo", [ + ("id", string), + ("width", uint32), + ("height", uint32), + ("req_evtch", integer), + ("req_rref", integer), + ("evt_evtch", integer), + ("evt_rref", integer), + ], dir=DIR_OUT) + +libxl_vdisplinfo = Struct("vdisplinfo", [ + ("backend", string), + ("backend_id", uint32), + ("frontend", string), + ("frontend_id", uint32), + ("devid", libxl_devid), + ("state", integer), + ("be_alloc", bool), + ("connectors", Array(libxl_connectorinfo, "num_connectors")) + ], dir=DIR_OUT) + # NUMA node characteristics: size and free are how much memory it has, and how # much of it is free, respectively. dists is an array of distances from this # node to each other node. diff --git a/tools/libxl/libxl_types_internal.idl b/tools/libxl/libxl_types_internal.idl index 7dc4d0f..673a6d5 100644 --- a/tools/libxl/libxl_types_internal.idl +++ b/tools/libxl/libxl_types_internal.idl @@ -26,6 +26,7 @@ libxl__device_kind = Enumeration("device_kind", [ (9, "VUSB"), (10, "QUSB"), (11, "9PFS"), + (12, "VDISPL"), ]) libxl__console_backend = Enumeration("console_backend", [