| Message ID | ff2eee2670f773454efdece4f455bb367fff3baa.1498722090.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 06/29/2017 12:43 AM, Arvind Yadav wrote: > dev_pm_ops are not supposed to change at runtime. All functions > working with dev_pm_ops provided by <linux/device.h> work with const > dev_pm_ops. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 17956 1456 8 19420 4bdc drivers/scsi/ibmvscsi/ibmvscsi.o > > File size After adding 'const': > text data bss dec hex filename > 18164 1264 8 19436 4bec drivers/scsi/ibmvscsi/ibmvscsi.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Acked-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Arvind, > dev_pm_ops are not supposed to change at runtime. All functions > working with dev_pm_ops provided by <linux/device.h> work with const > dev_pm_ops. So mark the non-const structs as const. Applied to 4.13/scsi-queue.
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 1deb0a9..da22b36 100644 --- a/drivers/scsi/ibmvscsi/ibmvscsi.c +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c @@ -2336,7 +2336,7 @@ static int ibmvscsi_resume(struct device *dev) }; MODULE_DEVICE_TABLE(vio, ibmvscsi_device_table); -static struct dev_pm_ops ibmvscsi_pm_ops = { +static const struct dev_pm_ops ibmvscsi_pm_ops = { .resume = ibmvscsi_resume };
dev_pm_ops are not supposed to change at runtime. All functions working with dev_pm_ops provided by <linux/device.h> work with const dev_pm_ops. So mark the non-const structs as const. File size before: text data bss dec hex filename 17956 1456 8 19420 4bdc drivers/scsi/ibmvscsi/ibmvscsi.o File size After adding 'const': text data bss dec hex filename 18164 1264 8 19436 4bec drivers/scsi/ibmvscsi/ibmvscsi.o Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)