| Message ID | 20170704084059.6278-4-el13635@mail.ntua.gr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 04.07.2017 um 10:40 hat Manos Pitsidianakis geschrieben: > Now that bdrv_truncate is passed to bs->file by default, remove the > callback from block/blkdebug.c > > Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr> We'll need to set .is_filter = true for blkdebug now. I haven't yet looked into the existing implications that this has, but intuitively this should be okay. When you do so, please explain in the commit message the implications that this has. Kevin
diff --git a/block/blkdebug.c b/block/blkdebug.c index b25856c4..5e118e10 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -821,11 +821,6 @@ static int64_t blkdebug_getlength(BlockDriverState *bs) return bdrv_getlength(bs->file->bs); } -static int blkdebug_truncate(BlockDriverState *bs, int64_t offset, Error **errp) -{ - return bdrv_truncate(bs->file, offset, errp); -} - static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options) { BDRVBlkdebugState *s = bs->opaque; @@ -916,7 +911,6 @@ static BlockDriver bdrv_blkdebug = { .bdrv_child_perm = bdrv_filter_default_perms, .bdrv_getlength = blkdebug_getlength, - .bdrv_truncate = blkdebug_truncate, .bdrv_refresh_filename = blkdebug_refresh_filename, .bdrv_refresh_limits = blkdebug_refresh_limits,
Now that bdrv_truncate is passed to bs->file by default, remove the callback from block/blkdebug.c Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr> --- block/blkdebug.c | 6 ------ 1 file changed, 6 deletions(-)