| Message ID | 1499071350-25168-14-git-send-email-inki.dae@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/03/2017 02:12 PM, Inki Dae wrote: > This patch removes unnecessary checking of return value. Can I get an ack from the maintainers to get this pulled in via drm-misc? Thanks, Archit > > Signed-off-by: Inki Dae <inki.dae@samsung.com> > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index 0a4ffd7..62652ee 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -1697,11 +1697,7 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev) > > hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs; > hdmi->bridge.of_node = pdev->dev.of_node; > - ret = drm_bridge_add(&hdmi->bridge); > - if (ret) { > - dev_err(dev, "failed to add bridge, ret = %d\n", ret); > - return ret; > - } > + drm_bridge_add(&hdmi->bridge); > > ret = mtk_hdmi_clk_enable_audio(hdmi); > if (ret) { >
On Wed, Jul 05, 2017 at 02:31:57PM +0530, Archit Taneja wrote: > > > On 07/03/2017 02:12 PM, Inki Dae wrote: > > This patch removes unnecessary checking of return value. > > Can I get an ack from the maintainers to get this pulled in > via drm-misc? Almost two weeks of no replies, I'd say go ahead and assume the maintainers are absent. That's what I generally do, otherwise it's pretty much impossible to land such cleanups. -Daniel > > Thanks, > Archit > > > > > Signed-off-by: Inki Dae <inki.dae@samsung.com> > > --- > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > index 0a4ffd7..62652ee 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > @@ -1697,11 +1697,7 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev) > > hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs; > > hdmi->bridge.of_node = pdev->dev.of_node; > > - ret = drm_bridge_add(&hdmi->bridge); > > - if (ret) { > > - dev_err(dev, "failed to add bridge, ret = %d\n", ret); > > - return ret; > > - } > > + drm_bridge_add(&hdmi->bridge); > > ret = mtk_hdmi_clk_enable_audio(hdmi); > > if (ret) { > > > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, 2017-08-18 at 10:54 +0200, Daniel Vetter wrote: > On Wed, Jul 05, 2017 at 02:31:57PM +0530, Archit Taneja wrote: > > > > > > On 07/03/2017 02:12 PM, Inki Dae wrote: > > > This patch removes unnecessary checking of return value. > > > > Can I get an ack from the maintainers to get this pulled in > > via drm-misc? > > Almost two weeks of no replies, I'd say go ahead and assume the > maintainers are absent. That's what I generally do, otherwise it's pretty > much impossible to land such cleanups. > -Daniel Yes, I'm absent, so go ahead. Acked-by: CK Hu <ck.hu@mediatek.com> > > > > > Thanks, > > Archit > > > > > > > > Signed-off-by: Inki Dae <inki.dae@samsung.com> > > > --- > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +----- > > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > index 0a4ffd7..62652ee 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > @@ -1697,11 +1697,7 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev) > > > hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs; > > > hdmi->bridge.of_node = pdev->dev.of_node; > > > - ret = drm_bridge_add(&hdmi->bridge); > > > - if (ret) { > > > - dev_err(dev, "failed to add bridge, ret = %d\n", ret); > > > - return ret; > > > - } > > > + drm_bridge_add(&hdmi->bridge); > > > ret = mtk_hdmi_clk_enable_audio(hdmi); > > > if (ret) { > > > > > > > -- > > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > > a Linux Foundation Collaborative Project > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel >
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 0a4ffd7..62652ee 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1697,11 +1697,7 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev) hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs; hdmi->bridge.of_node = pdev->dev.of_node; - ret = drm_bridge_add(&hdmi->bridge); - if (ret) { - dev_err(dev, "failed to add bridge, ret = %d\n", ret); - return ret; - } + drm_bridge_add(&hdmi->bridge); ret = mtk_hdmi_clk_enable_audio(hdmi); if (ret) {
This patch removes unnecessary checking of return value. Signed-off-by: Inki Dae <inki.dae@samsung.com> --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)