| Message ID | ff70f97b4eff56164bb164efcf2df2ef8ab6bf65.1499231308.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Jul 05, 2017 at 10:41:18AM +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by <linux/sysfs.h> work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 6161 9400 0 15561 3cc9 drivers/hwmon/nct7802.o > > File size After adding 'const': > text data bss dec hex filename > 6465 9080 0 15545 3cb9 drivers/hwmon/nct7802.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Ok, I messed up ;-). Took this version. Thanks, Guenter > --- > Changes in v1: > Subject was not correct. Now comparing size of nct7802.c > > drivers/hwmon/nct7802.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c > index 12b94b0..2876c18 100644 > --- a/drivers/hwmon/nct7802.c > +++ b/drivers/hwmon/nct7802.c > @@ -704,7 +704,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj, > return attr->mode; > } > > -static struct attribute_group nct7802_temp_group = { > +static const struct attribute_group nct7802_temp_group = { > .attrs = nct7802_temp_attrs, > .is_visible = nct7802_temp_is_visible, > }; > @@ -802,7 +802,7 @@ static umode_t nct7802_in_is_visible(struct kobject *kobj, > return attr->mode; > } > > -static struct attribute_group nct7802_in_group = { > +static const struct attribute_group nct7802_in_group = { > .attrs = nct7802_in_attrs, > .is_visible = nct7802_in_is_visible, > }; > @@ -880,7 +880,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj, > return attr->mode; > } > > -static struct attribute_group nct7802_fan_group = { > +static const struct attribute_group nct7802_fan_group = { > .attrs = nct7802_fan_attrs, > .is_visible = nct7802_fan_is_visible, > }; > @@ -898,7 +898,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj, > NULL > }; > > -static struct attribute_group nct7802_pwm_group = { > +static const struct attribute_group nct7802_pwm_group = { > .attrs = nct7802_pwm_attrs, > }; > > @@ -1011,7 +1011,7 @@ static SENSOR_DEVICE_ATTR(pwm3_auto_point4_pwm, S_IRUGO | S_IWUSR, > NULL > }; > > -static struct attribute_group nct7802_auto_point_group = { > +static const struct attribute_group nct7802_auto_point_group = { > .attrs = nct7802_auto_point_attrs, > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c index 12b94b0..2876c18 100644 --- a/drivers/hwmon/nct7802.c +++ b/drivers/hwmon/nct7802.c @@ -704,7 +704,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj, return attr->mode; } -static struct attribute_group nct7802_temp_group = { +static const struct attribute_group nct7802_temp_group = { .attrs = nct7802_temp_attrs, .is_visible = nct7802_temp_is_visible, }; @@ -802,7 +802,7 @@ static umode_t nct7802_in_is_visible(struct kobject *kobj, return attr->mode; } -static struct attribute_group nct7802_in_group = { +static const struct attribute_group nct7802_in_group = { .attrs = nct7802_in_attrs, .is_visible = nct7802_in_is_visible, }; @@ -880,7 +880,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj, return attr->mode; } -static struct attribute_group nct7802_fan_group = { +static const struct attribute_group nct7802_fan_group = { .attrs = nct7802_fan_attrs, .is_visible = nct7802_fan_is_visible, }; @@ -898,7 +898,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj, NULL }; -static struct attribute_group nct7802_pwm_group = { +static const struct attribute_group nct7802_pwm_group = { .attrs = nct7802_pwm_attrs, }; @@ -1011,7 +1011,7 @@ static SENSOR_DEVICE_ATTR(pwm3_auto_point4_pwm, S_IRUGO | S_IWUSR, NULL }; -static struct attribute_group nct7802_auto_point_group = { +static const struct attribute_group nct7802_auto_point_group = { .attrs = nct7802_auto_point_attrs, };
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 6161 9400 0 15561 3cc9 drivers/hwmon/nct7802.o File size After adding 'const': text data bss dec hex filename 6465 9080 0 15545 3cb9 drivers/hwmon/nct7802.o Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- Changes in v1: Subject was not correct. Now comparing size of nct7802.c drivers/hwmon/nct7802.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)