diff mbox

mmc: block: remove unused struct mmc_card *card

Message ID 1499329615-104052-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shawn Lin July 6, 2017, 8:26 a.m. UTC
It was never used and introduced a long standing compile
warning:

drivers/mmc/core/block.c: In function 'power_ro_lock_store':
drivers/mmc/core/block.c:191:19: warning: variable 'card' set but not
used [-Wunused-but-set-variable]

Remove it to fix the warning.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/mmc/core/block.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ulf Hansson July 11, 2017, 2:44 p.m. UTC | #1
On 6 July 2017 at 10:26, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> It was never used and introduced a long standing compile
> warning:
>
> drivers/mmc/core/block.c: In function 'power_ro_lock_store':
> drivers/mmc/core/block.c:191:19: warning: variable 'card' set but not
> used [-Wunused-but-set-variable]
>
> Remove it to fix the warning.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/core/block.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index 0cfac2d..4adde50 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -188,7 +188,6 @@ static ssize_t power_ro_lock_store(struct device *dev,
>  {
>         int ret;
>         struct mmc_blk_data *md, *part_md;
> -       struct mmc_card *card;
>         struct mmc_queue *mq;
>         struct request *req;
>         unsigned long set;
> @@ -201,7 +200,6 @@ static ssize_t power_ro_lock_store(struct device *dev,
>
>         md = mmc_blk_get(dev_to_disk(dev));
>         mq = &md->queue;
> -       card = md->queue.card;
>
>         /* Dispatch locking to the block layer */
>         req = blk_get_request(mq->queue, REQ_OP_DRV_OUT, __GFP_RECLAIM);
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index 0cfac2d..4adde50 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -188,7 +188,6 @@  static ssize_t power_ro_lock_store(struct device *dev,
 {
 	int ret;
 	struct mmc_blk_data *md, *part_md;
-	struct mmc_card *card;
 	struct mmc_queue *mq;
 	struct request *req;
 	unsigned long set;
@@ -201,7 +200,6 @@  static ssize_t power_ro_lock_store(struct device *dev,
 
 	md = mmc_blk_get(dev_to_disk(dev));
 	mq = &md->queue;
-	card = md->queue.card;
 
 	/* Dispatch locking to the block layer */
 	req = blk_get_request(mq->queue, REQ_OP_DRV_OUT, __GFP_RECLAIM);