[2/4] firwmare: enable a debug print for batched requests

Commit Message

Luis Chamberlain July 15, 2017, 9:18 p.m. UTC

Otherwise there is no easy way this actually happened.

Signed-off-by: Luis R. Rodriguez <[e-mail]>
---
 drivers/base/firmware_class.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Greg Kroah-Hartman July 17, 2017, 2:31 p.m. UTC | #1

On Sat, Jul 15, 2017 at 02:18:51PM -0700, Luis R. Rodriguez wrote:
> Otherwise there is no easy way this actually happened.
> 
> Signed-off-by: Luis R. Rodriguez <[e-mail]>

You misspelled "firmware" in the subject :(

Patch

diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 6f58a15efa2b..a85dabeb1e20 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -334,6 +334,7 @@  static struct firmware_buf *__fw_lookup_buf(const char *fw_name)
 	return NULL;
 }
 
+/* Returns 1 for batching firmware requests with the same name */
 static int fw_lookup_and_allocate_buf(const char *fw_name,
 				      struct firmware_cache *fwc,
 				      struct firmware_buf **buf, void *dbuf,
@@ -347,6 +348,7 @@  static int fw_lookup_and_allocate_buf(const char *fw_name,
 		kref_get(&tmp->ref);
 		spin_unlock(&fwc->lock);
 		*buf = tmp;
+		pr_debug("batched request - sharing the same struct firmware_buf and lookup for multiple requests\n");
 		return 1;
 	}
 	tmp = __allocate_fw_buf(fw_name, fwc, dbuf, size);