| Message ID | 149874098367.524.1300209233921079469.stgit@Solace (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 29, 2017 at 1:56 PM, Dario Faggioli <dario.faggioli@citrix.com> wrote: > Whether or not there's pending tasklet work to do, it's > something we know from the tasklet_work_scheduled parameter. > > Deal with that as soon as possible, like all other schedulers > do. > > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> Reviewed-by: George Dunlap <george.dunlap@citrix.com>
diff --git a/xen/common/sched_null.c b/xen/common/sched_null.c index 705c00a..610a150 100644 --- a/xen/common/sched_null.c +++ b/xen/common/sched_null.c @@ -641,7 +641,10 @@ static struct task_slice null_schedule(const struct scheduler *ops, SCHED_STAT_CRANK(schedule); NULL_VCPU_CHECK(current); - ret.task = per_cpu(npc, cpu).vcpu; + if ( tasklet_work_scheduled ) + ret.task = idle_vcpu[cpu]; + else + ret.task = per_cpu(npc, cpu).vcpu; ret.migrated = 0; ret.time = -1; @@ -663,9 +666,7 @@ static struct task_slice null_schedule(const struct scheduler *ops, spin_unlock(&prv->waitq_lock); } - if ( unlikely(tasklet_work_scheduled || - ret.task == NULL || - !vcpu_runnable(ret.task)) ) + if ( unlikely(ret.task == NULL || !vcpu_runnable(ret.task)) ) ret.task = idle_vcpu[cpu]; NULL_VCPU_CHECK(ret.task);
Whether or not there's pending tasklet work to do, it's something we know from the tasklet_work_scheduled parameter. Deal with that as soon as possible, like all other schedulers do. Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> --- Cc: George Dunlap <george.dunlap@eu.citrix.com> --- xen/common/sched_null.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)