| Message ID | 20170725154005.GA50912@lkp-hsx03.lkp.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, 2017-07-25 at 23:40 +0800, kbuild test robot wrote: > drivers/scsi/megaraid/megaraid_sas_fusion.c:608:2-18: WARNING: NULL > check before freeing functions like kfree, debugfs_remove, > debugfs_remove_recursive or usb_free_urb is not needed. Maybe > consider reorganizing relevant code to avoid passing NULL values. > drivers/scsi/megaraid/megaraid_sas_fusion.c:629:2-18: WARNING: NULL > check before freeing functions like kfree, debugfs_remove, > debugfs_remove_recursive or usb_free_urb is not needed. Maybe > consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. Hey, guys, we yelled at Markus Elfring for sending hundreds of patches like this. The reason then was too much code churn for too little value: the if() might be unnecessary but it really doesn't cost very much in terms of execution time, so the code churn disadvantage greatly outweighs any benefits. The reason hasn't changed, so please stop this otherwise you're going to turn the very valuable 0day test infrastructure into a thousand patch spambot. James
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -604,8 +604,7 @@ megasas_free_rdpq_fusion(struct megasas_ fusion->reply_frames_desc_phys[i]); } - if (fusion->reply_frames_desc_pool) - dma_pool_destroy(fusion->reply_frames_desc_pool); + dma_pool_destroy(fusion->reply_frames_desc_pool); if (fusion->rdpq_virt) pci_free_consistent(instance->pdev, @@ -625,8 +624,7 @@ megasas_free_reply_fusion(struct megasas fusion->reply_frames_desc[0], fusion->reply_frames_desc_phys[0]); - if (fusion->reply_frames_desc_pool) - dma_pool_destroy(fusion->reply_frames_desc_pool); + dma_pool_destroy(fusion->reply_frames_desc_pool); }
drivers/scsi/megaraid/megaraid_sas_fusion.c:608:2-18: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/scsi/megaraid/megaraid_sas_fusion.c:629:2-18: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: cbb80044a6c7 ("scsi: megaraid: Replace PCI pool old API") CC: Romain Perier <romain.perier@collabora.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- megaraid_sas_fusion.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)