| Message ID | 20170731111445.GA4844@symbol-HP-ZBook-15 (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On 07/31/2017 06:14 AM, Souptick Joarder wrote: > In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval > and hw->max_rate_tries are replaced by macro. That is NOT what your patch does. It only removes a comment! Granted, that comment is useless and should come out, but your commit message must be a little more accurate. NACK. Larry > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > --- > drivers/net/wireless/realtek/rtlwifi/base.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c > index f45d093..52f2d0b 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/base.c > +++ b/drivers/net/wireless/realtek/rtlwifi/base.c > @@ -422,7 +422,6 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw) > hw->extra_tx_headroom = RTL_TX_HEADER_SIZE; > > /* TODO: Correct this value for our hw */ > - /* defined these hard code values */ > hw->max_listen_interval = MAX_LISTEN_INTERVAL; > hw->max_rate_tries = MAX_RATE_TRIES; > /* hw->max_rates = 1; */ > -- > 1.9.1 > >
Larry Finger <Larry.Finger@lwfinger.net> writes: > On 07/31/2017 06:14 AM, Souptick Joarder wrote: >> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval >> and hw->max_rate_tries are replaced by macro. > > That is NOT what your patch does. It only removes a comment! Granted, > that comment is useless and should come out, but your commit message > must be a little more accurate. Actually the patch does not even apply, I suspect that Souptick incorrectly used v3 of his patch as the baseline for v4. Instead this v4 should be folded with v3.
Hi Kalle, On Wed, Aug 2, 2017 at 2:51 PM, Kalle Valo <kvalo@codeaurora.org> wrote: > Larry Finger <Larry.Finger@lwfinger.net> writes: > >> On 07/31/2017 06:14 AM, Souptick Joarder wrote: >>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval >>> and hw->max_rate_tries are replaced by macro. >> >> That is NOT what your patch does. It only removes a comment! Granted, >> that comment is useless and should come out, but your commit message >> must be a little more accurate. > > Actually the patch does not even apply, I suspect that Souptick > incorrectly used v3 of his patch as the baseline for v4. Instead this v4 > should be folded with v3. Do you mean I should address your comment in v3 and send v3 again instead of v4 ? > > -- > Kalle Valo -Souptick
On 8/2/2017 12:47 PM, Souptick Joarder wrote: > Hi Kalle, > > On Wed, Aug 2, 2017 at 2:51 PM, Kalle Valo <kvalo@codeaurora.org> wrote: >> Larry Finger <Larry.Finger@lwfinger.net> writes: >> >>> On 07/31/2017 06:14 AM, Souptick Joarder wrote: >>>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval >>>> and hw->max_rate_tries are replaced by macro. >>> >>> That is NOT what your patch does. It only removes a comment! Granted, >>> that comment is useless and should come out, but your commit message >>> must be a little more accurate. >> >> Actually the patch does not even apply, I suspect that Souptick >> incorrectly used v3 of his patch as the baseline for v4. Instead this v4 >> should be folded with v3. > > Do you mean I should address your comment in v3 and send v3 again > instead of v4 ? Your v4 patch should apply on top of wireless-drivers-next/master as is. Regards, Arend
diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c index f45d093..52f2d0b 100644 --- a/drivers/net/wireless/realtek/rtlwifi/base.c +++ b/drivers/net/wireless/realtek/rtlwifi/base.c @@ -422,7 +422,6 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw) hw->extra_tx_headroom = RTL_TX_HEADER_SIZE; /* TODO: Correct this value for our hw */ - /* defined these hard code values */ hw->max_listen_interval = MAX_LISTEN_INTERVAL; hw->max_rate_tries = MAX_RATE_TRIES; /* hw->max_rates = 1; */
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro. Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/base.c | 1 - 1 file changed, 1 deletion(-) -- 1.9.1