| Message ID | 1501704371-28151-1-git-send-email-martin@kaiser.cx (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > the addresses used by tscadc and those in its child nodes (adc, tsc). > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > drivers will then fail since there's no IORESOURCE_MEM. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Do we need the following Fixes tag? Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") @Markus, we didn't the changes when we were submitting? Shawn > --- > arch/arm/boot/dts/imx25.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 0d2f3a1..1e37bd3 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -297,6 +297,7 @@ > #address-cells = <1>; > #size-cells = <1>; > status = "disabled"; > + ranges; > > adc: adc@50030800 { > compatible = "fsl,imx25-gcq"; > -- > 2.1.4 >
Hi Shawn, Thus wrote Shawn Guo (shawnguo@kernel.org): > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > > the addresses used by tscadc and those in its child nodes (adc, tsc). > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > > drivers will then fail since there's no IORESOURCE_MEM. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > Do we need the following Fixes tag? > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") yes, looks like this has never worked correctly. If you're ok with the fix, I can add the tag in v2. > @Markus, we didn't the changes when we were submitting? Both Markus' and Denis' mail addresses bounced... Best regards, Martin
On Thu, Aug 03, 2017 at 06:29:48PM +0200, Martin Kaiser wrote: > Hi Shawn, > > Thus wrote Shawn Guo (shawnguo@kernel.org): > > > On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote: > > > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between > > > the addresses used by tscadc and those in its child nodes (adc, tsc). > > > > Without such a mapping, the reg = ... lines in the tsc and adc nodes do > > > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc > > > drivers will then fail since there's no IORESOURCE_MEM. > > > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > > > Do we need the following Fixes tag? > > > Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support") > > yes, looks like this has never worked correctly. > > If you're ok with the fix, I can add the tag in v2. I added the Fixes tag and applied the patch. Thanks. Shawn
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 0d2f3a1..1e37bd3 100644 --- a/arch/arm/boot/dts/imx25.dtsi +++ b/arch/arm/boot/dts/imx25.dtsi @@ -297,6 +297,7 @@ #address-cells = <1>; #size-cells = <1>; status = "disabled"; + ranges; adc: adc@50030800 { compatible = "fsl,imx25-gcq";
Add a ranges; line to the tscadc node. This creates a 1:1 mapping between the addresses used by tscadc and those in its child nodes (adc, tsc). Without such a mapping, the reg = ... lines in the tsc and adc nodes do not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc drivers will then fail since there's no IORESOURCE_MEM. Signed-off-by: Martin Kaiser <martin@kaiser.cx> --- arch/arm/boot/dts/imx25.dtsi | 1 + 1 file changed, 1 insertion(+)