diff mbox

[v2,3/5] aic7xxx: remove rules for shipped files

Message ID 759ba18717a785f8875b74efe01ba26920d55006.1501802727.git.mirq-linux@rere.qmqm.pl (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Michał Mirosław Aug. 3, 2017, 11:28 p.m. UTC 
There are Kbuild rules for that already.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
 drivers/scsi/aic7xxx/Makefile | 4 ----
 1 file changed, 4 deletions(-)

Comments

Hannes Reinecke Aug. 4, 2017, 8:41 a.m. UTC | #1 
On 08/04/2017 01:28 AM, Michał Mirosław wrote:
> There are Kbuild rules for that already.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
>  drivers/scsi/aic7xxx/Makefile | 4 ----
>  1 file changed, 4 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
Michał Mirosław Aug. 9, 2017, 10:27 p.m. UTC | #2 
On Fri, Aug 04, 2017 at 01:28:09AM +0200, Michał Mirosław wrote:
[...]
> --- a/drivers/scsi/aic7xxx/Makefile
> +++ b/drivers/scsi/aic7xxx/Makefile
> @@ -61,8 +61,6 @@ $(obj)/aic7xxx_seq.h: $(src)/aic7xxx.seq $(src)/aic7xxx.reg $(obj)/aicasm/aicasm
[...]
> -else
> -$(obj)/aic7xxx_reg_print.c: $(src)/aic7xxx_reg_print.c_shipped
[...]

Hi,

Please drop this patch (only this one). I didn't notice, that the file is
needed by modpost:

      Building modules, stage 2.
      MODPOST 785 modules
    WARNING: could not open drivers/scsi/aic7xxx/aic79xx_reg_print.c: No
such file or directory
      LD [M]  drivers/scsi/aic7xxx/aic79xx.ko

Best Regards,
Michał Mirosław
Martin K. Petersen Aug. 10, 2017, 11:37 p.m. UTC | #3 
Michał,

> Please drop this patch (only this one). I didn't notice, that the file
> is needed by modpost:

OK, done.
diff mbox

Patch

diff --git a/drivers/scsi/aic7xxx/Makefile b/drivers/scsi/aic7xxx/Makefile
index b03ba0df7a83..1a5509d40f8a 100644
--- a/drivers/scsi/aic7xxx/Makefile
+++ b/drivers/scsi/aic7xxx/Makefile
@@ -61,8 +61,6 @@  $(obj)/aic7xxx_seq.h: $(src)/aic7xxx.seq $(src)/aic7xxx.reg $(obj)/aicasm/aicasm
 
 $(aic7xxx-gen-y): $(objtree)/$(obj)/aic7xxx_seq.h
 	@true
-else
-$(obj)/aic7xxx_reg_print.c: $(src)/aic7xxx_reg_print.c_shipped
 endif
 
 aic79xx-gen-$(CONFIG_AIC79XX_BUILD_FIRMWARE)	:= $(obj)/aic79xx_reg.h
@@ -79,8 +77,6 @@  $(obj)/aic79xx_seq.h: $(src)/aic79xx.seq $(src)/aic79xx.reg $(obj)/aicasm/aicasm
 
 $(aic79xx-gen-y): $(objtree)/$(obj)/aic79xx_seq.h
 	@true
-else
-$(obj)/aic79xx_reg_print.c: $(src)/aic79xx_reg_print.c_shipped
 endif
 
 $(obj)/aicasm/aicasm: $(srctree)/$(src)/aicasm/*.[chyl]