diff mbox

cpufreq: Simplify cpufreq_can_do_remote_dvfs()

Message ID 1957547.1DvPFJ11E3@aspire.rjw.lan (mailing list archive)
State Mainlined
Delegated to: Rafael Wysocki
Headers show

Commit Message

Rafael J. Wysocki Aug. 4, 2017, 12:57 p.m. UTC 
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

The if () in cpufreq_can_do_remote_dvfs() is superfluous, so drop
it and simply return the value of the expression under it.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

On top of the current linux-next.

---
 include/linux/cpufreq.h |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Viresh Kumar Aug. 7, 2017, 3:33 a.m. UTC | #1 
On 04-08-17, 14:57, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The if () in cpufreq_can_do_remote_dvfs() is superfluous, so drop
> it and simply return the value of the expression under it.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> 
> On top of the current linux-next.
> 
> ---
>  include/linux/cpufreq.h |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> Index: linux-pm/include/linux/cpufreq.h
> ===================================================================
> --- linux-pm.orig/include/linux/cpufreq.h
> +++ linux-pm/include/linux/cpufreq.h
> @@ -578,11 +578,8 @@ static inline bool cpufreq_can_do_remote
>  	 * - dvfs_possible_from_any_cpu flag is set
>  	 * - the local and remote CPUs share cpufreq policy
>  	 */
> -	if (policy->dvfs_possible_from_any_cpu ||
> -	    cpumask_test_cpu(smp_processor_id(), policy->cpus))
> -		return true;
> -
> -	return false;
> +	return policy->dvfs_possible_from_any_cpu ||
> +		cpumask_test_cpu(smp_processor_id(), policy->cpus);
>  }
>  
>  /*********************************************************************

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff mbox

Patch

Index: linux-pm/include/linux/cpufreq.h
===================================================================
--- linux-pm.orig/include/linux/cpufreq.h
+++ linux-pm/include/linux/cpufreq.h
@@ -578,11 +578,8 @@  static inline bool cpufreq_can_do_remote
 	 * - dvfs_possible_from_any_cpu flag is set
 	 * - the local and remote CPUs share cpufreq policy
 	 */
-	if (policy->dvfs_possible_from_any_cpu ||
-	    cpumask_test_cpu(smp_processor_id(), policy->cpus))
-		return true;
-
-	return false;
+	return policy->dvfs_possible_from_any_cpu ||
+		cpumask_test_cpu(smp_processor_id(), policy->cpus);
 }
 
 /*********************************************************************