| Message ID | 20170804104506.2414-1-peda@axentia.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On 04-08-17 12:45, Peter Rosin wrote: > The redundant fb helpers .load_lut, .gamma_set and .gamma_get are > no longer used. Remove the dead code that was not doing anything > sensible anyway. > > Signed-off-by: Peter Rosin <peda@axentia.se> Thank you, patch looks good to me: Acked-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/staging/vboxvideo/vbox_fb.c | 15 --------------- > drivers/staging/vboxvideo/vbox_mode.c | 5 ----- > 2 files changed, 20 deletions(-) > > [This time with an improved Cc list, sorry for the noise. For new > people, please refer to https://lkml.org/lkml/2017/7/13/593 for > context] > > Hi Daniel, > > Here it goes, but do you really need me to resend v5 14/14? > > Cheers, > peda > > diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c > index 35f6d9f8c203..bf6635826159 100644 > --- a/drivers/staging/vboxvideo/vbox_fb.c > +++ b/drivers/staging/vboxvideo/vbox_fb.c > @@ -317,22 +317,7 @@ static int vboxfb_create(struct drm_fb_helper *helper, > return 0; > } > > -static void vbox_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green, > - u16 blue, int regno) > -{ > -} > - > -static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green, > - u16 *blue, int regno) > -{ > - *red = regno; > - *green = regno; > - *blue = regno; > -} > - > static struct drm_fb_helper_funcs vbox_fb_helper_funcs = { > - .gamma_set = vbox_fb_gamma_set, > - .gamma_get = vbox_fb_gamma_get, > .fb_probe = vboxfb_create, > }; > > diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c > index f2b85f3256fa..996da1c79158 100644 > --- a/drivers/staging/vboxvideo/vbox_mode.c > +++ b/drivers/staging/vboxvideo/vbox_mode.c > @@ -134,10 +134,6 @@ static int vbox_set_view(struct drm_crtc *crtc) > return 0; > } > > -static void vbox_crtc_load_lut(struct drm_crtc *crtc) > -{ > -} > - > static void vbox_crtc_dpms(struct drm_crtc *crtc, int mode) > { > struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc); > @@ -330,7 +326,6 @@ static const struct drm_crtc_helper_funcs vbox_crtc_helper_funcs = { > .mode_set = vbox_crtc_mode_set, > /* .mode_set_base = vbox_crtc_mode_set_base, */ > .disable = vbox_crtc_disable, > - .load_lut = vbox_crtc_load_lut, > .prepare = vbox_crtc_prepare, > .commit = vbox_crtc_commit, > }; >
On Fri, Aug 04, 2017 at 12:45:06PM +0200, Peter Rosin wrote: > The redundant fb helpers .load_lut, .gamma_set and .gamma_get are > no longer used. Remove the dead code that was not doing anything > sensible anyway. > > Signed-off-by: Peter Rosin <peda@axentia.se> > --- > drivers/staging/vboxvideo/vbox_fb.c | 15 --------------- > drivers/staging/vboxvideo/vbox_mode.c | 5 ----- > 2 files changed, 20 deletions(-) > > [This time with an improved Cc list, sorry for the noise. For new > people, please refer to https://lkml.org/lkml/2017/7/13/593 for > context] > > Hi Daniel, > > Here it goes, but do you really need me to resend v5 14/14? Well it's not yet on dri-devel, but our pre-merge CI bots can't read such instructions. They expect a clean new series that applies cleanly, as a top-post, when resending stuff. Anyway, applied. Thanks, Daniel > > Cheers, > peda > > diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c > index 35f6d9f8c203..bf6635826159 100644 > --- a/drivers/staging/vboxvideo/vbox_fb.c > +++ b/drivers/staging/vboxvideo/vbox_fb.c > @@ -317,22 +317,7 @@ static int vboxfb_create(struct drm_fb_helper *helper, > return 0; > } > > -static void vbox_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green, > - u16 blue, int regno) > -{ > -} > - > -static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green, > - u16 *blue, int regno) > -{ > - *red = regno; > - *green = regno; > - *blue = regno; > -} > - > static struct drm_fb_helper_funcs vbox_fb_helper_funcs = { > - .gamma_set = vbox_fb_gamma_set, > - .gamma_get = vbox_fb_gamma_get, > .fb_probe = vboxfb_create, > }; > > diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c > index f2b85f3256fa..996da1c79158 100644 > --- a/drivers/staging/vboxvideo/vbox_mode.c > +++ b/drivers/staging/vboxvideo/vbox_mode.c > @@ -134,10 +134,6 @@ static int vbox_set_view(struct drm_crtc *crtc) > return 0; > } > > -static void vbox_crtc_load_lut(struct drm_crtc *crtc) > -{ > -} > - > static void vbox_crtc_dpms(struct drm_crtc *crtc, int mode) > { > struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc); > @@ -330,7 +326,6 @@ static const struct drm_crtc_helper_funcs vbox_crtc_helper_funcs = { > .mode_set = vbox_crtc_mode_set, > /* .mode_set_base = vbox_crtc_mode_set_base, */ > .disable = vbox_crtc_disable, > - .load_lut = vbox_crtc_load_lut, > .prepare = vbox_crtc_prepare, > .commit = vbox_crtc_commit, > }; > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 2017-08-07 11:21, Daniel Vetter wrote: > On Fri, Aug 04, 2017 at 12:45:06PM +0200, Peter Rosin wrote: >> The redundant fb helpers .load_lut, .gamma_set and .gamma_get are >> no longer used. Remove the dead code that was not doing anything >> sensible anyway. >> >> Signed-off-by: Peter Rosin <peda@axentia.se> >> --- >> drivers/staging/vboxvideo/vbox_fb.c | 15 --------------- >> drivers/staging/vboxvideo/vbox_mode.c | 5 ----- >> 2 files changed, 20 deletions(-) >> >> [This time with an improved Cc list, sorry for the noise. For new >> people, please refer to https://lkml.org/lkml/2017/7/13/593 for >> context] >> >> Hi Daniel, >> >> Here it goes, but do you really need me to resend v5 14/14? > > Well it's not yet on dri-devel, but our pre-merge CI bots can't read such > instructions. They expect a clean new series that applies cleanly, as a > top-post, when resending stuff. Ok, noted for the next time. These things seem to vary from subsystem to subsystem, so it's not trivial to get it right w/o investing serious time looking things up. Anyway, sorry about the trouble. > Anyway, applied. Thanks! Cheers, Peter
On Tue, Aug 08, 2017 at 01:54:52PM +0200, Peter Rosin wrote: > On 2017-08-07 11:21, Daniel Vetter wrote: > > On Fri, Aug 04, 2017 at 12:45:06PM +0200, Peter Rosin wrote: > >> The redundant fb helpers .load_lut, .gamma_set and .gamma_get are > >> no longer used. Remove the dead code that was not doing anything > >> sensible anyway. > >> > >> Signed-off-by: Peter Rosin <peda@axentia.se> > >> --- > >> drivers/staging/vboxvideo/vbox_fb.c | 15 --------------- > >> drivers/staging/vboxvideo/vbox_mode.c | 5 ----- > >> 2 files changed, 20 deletions(-) > >> > >> [This time with an improved Cc list, sorry for the noise. For new > >> people, please refer to https://lkml.org/lkml/2017/7/13/593 for > >> context] > >> > >> Hi Daniel, > >> > >> Here it goes, but do you really need me to resend v5 14/14? > > > > Well it's not yet on dri-devel, but our pre-merge CI bots can't read such > > instructions. They expect a clean new series that applies cleanly, as a > > top-post, when resending stuff. > > Ok, noted for the next time. These things seem to vary from subsystem to > subsystem, so it's not trivial to get it right w/o investing serious time > looking things up. Anyway, sorry about the trouble. Yes I know, the kernel is absolutely terrible with minor differences in process between subsystems. And then getting sternly reprimanded if you don't know them all :-( Unfortunately our CI has the same problem, it can't parse all the different flavours of how people re-submit patches, so we just had to standardize on something. -Daniel
diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c index 35f6d9f8c203..bf6635826159 100644 --- a/drivers/staging/vboxvideo/vbox_fb.c +++ b/drivers/staging/vboxvideo/vbox_fb.c @@ -317,22 +317,7 @@ static int vboxfb_create(struct drm_fb_helper *helper, return 0; } -static void vbox_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green, - u16 blue, int regno) -{ -} - -static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green, - u16 *blue, int regno) -{ - *red = regno; - *green = regno; - *blue = regno; -} - static struct drm_fb_helper_funcs vbox_fb_helper_funcs = { - .gamma_set = vbox_fb_gamma_set, - .gamma_get = vbox_fb_gamma_get, .fb_probe = vboxfb_create, }; diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c index f2b85f3256fa..996da1c79158 100644 --- a/drivers/staging/vboxvideo/vbox_mode.c +++ b/drivers/staging/vboxvideo/vbox_mode.c @@ -134,10 +134,6 @@ static int vbox_set_view(struct drm_crtc *crtc) return 0; } -static void vbox_crtc_load_lut(struct drm_crtc *crtc) -{ -} - static void vbox_crtc_dpms(struct drm_crtc *crtc, int mode) { struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc); @@ -330,7 +326,6 @@ static const struct drm_crtc_helper_funcs vbox_crtc_helper_funcs = { .mode_set = vbox_crtc_mode_set, /* .mode_set_base = vbox_crtc_mode_set_base, */ .disable = vbox_crtc_disable, - .load_lut = vbox_crtc_load_lut, .prepare = vbox_crtc_prepare, .commit = vbox_crtc_commit, };
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code that was not doing anything sensible anyway. Signed-off-by: Peter Rosin <peda@axentia.se> --- drivers/staging/vboxvideo/vbox_fb.c | 15 --------------- drivers/staging/vboxvideo/vbox_mode.c | 5 ----- 2 files changed, 20 deletions(-) [This time with an improved Cc list, sorry for the noise. For new people, please refer to https://lkml.org/lkml/2017/7/13/593 for context] Hi Daniel, Here it goes, but do you really need me to resend v5 14/14? Cheers, peda