| Message ID | d816c664-5d28-e924-2515-b0cc7ef46498@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Tue, Aug 01, 2017 at 01:45:36PM -0500, Brian King wrote: > If a SES device returns an error on a requested diagnostic page, > we are currently printing an error indicating the wrong page > was received. Fix this up to simply return a failure and only > check the returned page when the diagnostic page buffer was > populated by the device. > > Signed-off-by: Brian King <brking@linux.vnet.ibm.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c index f1cdf32..8927f9f5 100644 --- a/drivers/scsi/ses.c +++ b/drivers/scsi/ses.c @@ -99,7 +99,7 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code, ret = scsi_execute_req(sdev, cmd, DMA_FROM_DEVICE, buf, bufflen, NULL, SES_TIMEOUT, SES_RETRIES, NULL); - if (unlikely(!ret)) + if (unlikely(ret)) return ret; recv_page_code = ((unsigned char *)buf)[0];
If a SES device returns an error on a requested diagnostic page, we are currently printing an error indicating the wrong page was received. Fix this up to simply return a failure and only check the returned page when the diagnostic page buffer was populated by the device. Signed-off-by: Brian King <brking@linux.vnet.ibm.com> --- drivers/scsi/ses.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)