| Message ID | 1502340898-28403-4-git-send-email-jeffy.chen@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 10, 2017 at 12:54:58PM +0800, Jeffy Chen wrote: > Add a new rockchip,codec-names property, so that the driver can parse > the codecs by name. Why? You're already referencing the CODECs by phandle and these names are not part of any ABI...
Hi Mark, On 08/10/2017 10:56 PM, Mark Brown wrote: > On Thu, Aug 10, 2017 at 12:54:58PM +0800, Jeffy Chen wrote: >> Add a new rockchip,codec-names property, so that the driver can parse >> the codecs by name. > > Why? You're already referencing the CODECs by phandle and these names > are not part of any ABI... > currently we are binding the phandles to a fixed codec list in the driver. but we want to make it dynamic, since some exist codecs could be optional, and some new codecs could be add for new board too. and the support of this new property in the driver is added in https://patchwork.kernel.org/patch/9892737
On Thu, Aug 10, 2017 at 12:54:58PM +0800, Jeffy Chen wrote: > Add a new rockchip,codec-names property, so that the driver can parse > the codecs by name. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > --- > > Changes in v2: > Let rockchip,codec-names be a required property. > > Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt b/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt > index eac91db..05351df 100644 > --- a/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt > +++ b/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt > @@ -5,6 +5,7 @@ Required properties: > - rockchip,cpu: The phandle of the Rockchip I2S controller that's > connected to the codecs > - rockchip,codec: The phandle of the MAX98357A/RT5514/DA7219 codecs > +- rockchip,codec-names: The names of the MAX98357A/RT5514/DA7219 codecs No, just lookup the handle and get the compatible for the codec if you need a name. > > Optional properties: > - dmic-wakeup-delay-ms : specify delay time (ms) for DMIC ready. > @@ -18,5 +19,6 @@ sound { > compatible = "rockchip,rk3399-gru-sound"; > rockchip,cpu = <&i2s0>; > rockchip,codec = <&max98357a &rt5514 &da7219>; > + rockchip,codec-names = "MAX98357A", "RT5514", "DA7219"; > dmic-wakeup-delay-ms = <20>; > }; > -- > 2.1.4 > >
diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt b/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt index eac91db..05351df 100644 --- a/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt +++ b/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt @@ -5,6 +5,7 @@ Required properties: - rockchip,cpu: The phandle of the Rockchip I2S controller that's connected to the codecs - rockchip,codec: The phandle of the MAX98357A/RT5514/DA7219 codecs +- rockchip,codec-names: The names of the MAX98357A/RT5514/DA7219 codecs Optional properties: - dmic-wakeup-delay-ms : specify delay time (ms) for DMIC ready. @@ -18,5 +19,6 @@ sound { compatible = "rockchip,rk3399-gru-sound"; rockchip,cpu = <&i2s0>; rockchip,codec = <&max98357a &rt5514 &da7219>; + rockchip,codec-names = "MAX98357A", "RT5514", "DA7219"; dmic-wakeup-delay-ms = <20>; };
Add a new rockchip,codec-names property, so that the driver can parse the codecs by name. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> --- Changes in v2: Let rockchip,codec-names be a required property. Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt | 2 ++ 1 file changed, 2 insertions(+)