| Message ID | 20170814070849.20986-41-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 14.08.17 at 09:08, <jgross@suse.com> wrote: > With _cmdline_parse() now issuing error messages in case of illegal > parameters signalled by parsing functions specified in custom_param() > the message issued by apic_set_verbosity() can be removed. > > Cc: Jan Beulich <jbeulich@suse.com> > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Juergen Gross <jgross@suse.com> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c index fdb0a99927..5ffbd8f54f 100644 --- a/xen/arch/x86/apic.c +++ b/xen/arch/x86/apic.c @@ -800,11 +800,8 @@ static int __init apic_set_verbosity(char *str) apic_verbosity = APIC_DEBUG; else if (strcmp("verbose", str) == 0) apic_verbosity = APIC_VERBOSE; - else { - printk(KERN_WARNING "APIC Verbosity level %s not recognised" - " use apic_verbosity=verbose or apic_verbosity=debug", str); + else return -EINVAL; - } return 0; }
With _cmdline_parse() now issuing error messages in case of illegal parameters signalled by parsing functions specified in custom_param() the message issued by apic_set_verbosity() can be removed. Cc: Jan Beulich <jbeulich@suse.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Juergen Gross <jgross@suse.com> --- xen/arch/x86/apic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)