| Message ID | 1502813574-6040-2-git-send-email-sagi@grimberg.me (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
> create_workqueue always creates the worqeueu with WQ_MEM_RECLAIM Typo "worqeueu" -> "workqueue" > and silences a flush dependancy warn for WQ_LEGACY. Instead, we > want to keep the warn in case the allocator tries to flush the > cm workqueue because its very likely that cm work execution will > yield memory allocations (for example cm connection requests) . > > Reported-by: Steve Wise <swise@opengridcomputing.com> > Signed-off-by: Sagi Grimberg <sagi@grimberg.me> The change looks good. Reviewed-by: Steve Wise <swise@opengridcomputing.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 15, 2017 at 12:30:12PM -0500, Steve Wise wrote: > > create_workqueue always creates the worqeueu with WQ_MEM_RECLAIM > > Typo "worqeueu" -> "workqueue" > > > and silences a flush dependancy warn for WQ_LEGACY. Instead, we > > want to keep the warn in case the allocator tries to flush the > > cm workqueue because its very likely that cm work execution will > > yield memory allocations (for example cm connection requests) . And extra space before the last dot. Reviewed-by: Leon Romanovsky <leonro@mellanox.com> > > > > Reported-by: Steve Wise <swise@opengridcomputing.com> > > Signed-off-by: Sagi Grimberg <sagi@grimberg.me> > > The change looks good. > > Reviewed-by: Steve Wise <swise@opengridcomputing.com> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c index 2b4d613a3474..838e3507eadc 100644 --- a/drivers/infiniband/core/cm.c +++ b/drivers/infiniband/core/cm.c @@ -4201,7 +4201,7 @@ static int __init ib_cm_init(void) goto error1; } - cm.wq = create_workqueue("ib_cm"); + cm.wq = alloc_workqueue("ib_cm", 0, 1); if (!cm.wq) { ret = -ENOMEM; goto error2;
create_workqueue always creates the worqeueu with WQ_MEM_RECLAIM and silences a flush dependancy warn for WQ_LEGACY. Instead, we want to keep the warn in case the allocator tries to flush the cm workqueue because its very likely that cm work execution will yield memory allocations (for example cm connection requests) . Reported-by: Steve Wise <swise@opengridcomputing.com> Signed-off-by: Sagi Grimberg <sagi@grimberg.me> --- drivers/infiniband/core/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)