| Message ID | 1502889748-31499-7-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Ulrich, Thank you for the patch. On Wednesday 16 Aug 2017 15:22:28 Ulrich Hecht wrote: > This adds a new DT property to define the index used by a multiplexer to > select the device. > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > --- > Documentation/devicetree/bindings/serial/slave-device.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/slave-device.txt > b/Documentation/devicetree/bindings/serial/slave-device.txt index > 40110e0..f9b0783 100644 > --- a/Documentation/devicetree/bindings/serial/slave-device.txt > +++ b/Documentation/devicetree/bindings/serial/slave-device.txt > @@ -30,6 +30,8 @@ Optional Properties: > way to reset the device > * device baud rate is configured by its firmware but > there is no way to request the actual settings > +- reg : Index used to select the device if it is controlled by a > + multiplexer. The reg property should describe the device address on the bus it is connected to. This seems like an abuse of the property to me. The device shouldn't care about the multiplexer, I think you should describe the hardware by adding the serial device's DT node as a child of the multiplexer's port it is connected to. > Example:
diff --git a/Documentation/devicetree/bindings/serial/slave-device.txt b/Documentation/devicetree/bindings/serial/slave-device.txt index 40110e0..f9b0783 100644 --- a/Documentation/devicetree/bindings/serial/slave-device.txt +++ b/Documentation/devicetree/bindings/serial/slave-device.txt @@ -30,6 +30,8 @@ Optional Properties: way to reset the device * device baud rate is configured by its firmware but there is no way to request the actual settings +- reg : Index used to select the device if it is controlled by a + multiplexer. Example:
This adds a new DT property to define the index used by a multiplexer to select the device. Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> --- Documentation/devicetree/bindings/serial/slave-device.txt | 2 ++ 1 file changed, 2 insertions(+)