| Message ID | 20170815130638.31718-3-sergey.matyukevich.os@quantenna.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7376947dfb8094b7c8307d61f49ce48d4d6aec09 |
| Delegated to: | Kalle Valo |
| Headers | show |
Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> writes:
> Use napi_gro_receive() rather than netif_receive_skb() in qtnfmac driver.
Yes, I can easily see that from the diff so no need to document that :)
But the commit log should tell _why_ you did it.
Kalle Valo <kvalo@codeaurora.org> writes: > Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> writes: > >> Use napi_gro_receive() rather than netif_receive_skb() in qtnfmac driver. > > Yes, I can easily see that from the diff so no need to document that :) > But the commit log should tell _why_ you did it. And no need to resend because of this, I can improve the commit log during commit. Just let me know what I should add.
> >> Use napi_gro_receive() rather than netif_receive_skb() in qtnfmac driver. > > > > Yes, I can easily see that from the diff so no need to document that :) > > But the commit log should tell _why_ you did it. > > And no need to resend because of this, I can improve the commit log > during commit. Just let me know what I should add. Sure. The motivation is to improve performance when GRO is enabled, e.g. by reducing the number of TCP ACKs. Updated message would be: Use napi_gro_receive() rather than netif_receive_skb() to improve performance when GRO is enabled. Regards, Sergey
diff --git a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c index ae8acc1bf291..08b35dc30bc8 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c +++ b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c @@ -762,7 +762,7 @@ static int qtnf_rx_poll(struct napi_struct *napi, int budget) ndev->stats.rx_bytes += skb->len; skb->protocol = eth_type_trans(skb, ndev); - netif_receive_skb(skb); + napi_gro_receive(napi, skb); } else { pr_debug("drop untagged skb\n"); bus->mux_dev.stats.rx_dropped++;
Use napi_gro_receive() rather than netif_receive_skb() in qtnfmac driver. Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)