| Message ID | 38726390c030dc256d7dd169a416bc4a9814cbf7.1502617113.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On 13-08-17, 15:10, Arvind Yadav wrote: > platform_device_id are not supposed to change at runtime. All functions > working with platform_device_id provided by <linux/platform_device.h> > work with const platform_device_id. So mark the non-const structs as > const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/cpufreq/loongson2_cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c > index 9ac27b2..da34469 100644 > --- a/drivers/cpufreq/loongson2_cpufreq.c > +++ b/drivers/cpufreq/loongson2_cpufreq.c > @@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = { > .attr = cpufreq_generic_attr, > }; > > -static struct platform_device_id platform_device_ids[] = { > +static const struct platform_device_id platform_device_ids[] = { > { > .name = "loongson2_cpufreq", > }, Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Wednesday, August 16, 2017 5:25:59 AM CEST Viresh Kumar wrote: > On 13-08-17, 15:10, Arvind Yadav wrote: > > platform_device_id are not supposed to change at runtime. All functions > > working with platform_device_id provided by <linux/platform_device.h> > > work with const platform_device_id. So mark the non-const structs as > > const. > > > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > > --- > > drivers/cpufreq/loongson2_cpufreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c > > index 9ac27b2..da34469 100644 > > --- a/drivers/cpufreq/loongson2_cpufreq.c > > +++ b/drivers/cpufreq/loongson2_cpufreq.c > > @@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = { > > .attr = cpufreq_generic_attr, > > }; > > > > -static struct platform_device_id platform_device_ids[] = { > > +static const struct platform_device_id platform_device_ids[] = { > > { > > .name = "loongson2_cpufreq", > > }, > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > Applied, thanks!
diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c index 9ac27b2..da34469 100644 --- a/drivers/cpufreq/loongson2_cpufreq.c +++ b/drivers/cpufreq/loongson2_cpufreq.c @@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = { .attr = cpufreq_generic_attr, }; -static struct platform_device_id platform_device_ids[] = { +static const struct platform_device_id platform_device_ids[] = { { .name = "loongson2_cpufreq", },
platform_device_id are not supposed to change at runtime. All functions working with platform_device_id provided by <linux/platform_device.h> work with const platform_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/cpufreq/loongson2_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)