| Message ID | 20170807190906.7360-1-smayhew@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/07/2017 03:09 PM, Scott Mayhew wrote: > nfs-utils and libnfsidmap have similar configuration parsing routines. > They were the same up until nfs-utils commit 7b33590f (config: Remove > the conf_path global), where conf_init() was changed to take a path as > an argument. With the current idmap_LDADD ordering in Makefile.am, the > conf_init() from libnfsidmap is called, resulting in the following error > along with the failure to parse idmapd.conf: > > rpc.idmapd[391]: rpc.idmapd: conf_reinit: open ("(null)", O_RDONLY) failed > > Placing libnfs.a first in idmap_LDADD ensures that idmapd uses the config > parsing routines from nfs-utils instead of libnfsidmap. > > Signed-off-by: Scott Mayhew <smayhew@redhat.com> Committed.... steved. > --- > utils/idmapd/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utils/idmapd/Makefile.am b/utils/idmapd/Makefile.am > index c2f8ba1..1e8e9e6 100644 > --- a/utils/idmapd/Makefile.am > +++ b/utils/idmapd/Makefile.am > @@ -15,7 +15,7 @@ idmapd_SOURCES = \ > nfs_idmap.h \ > queue.h > > -idmapd_LDADD = $(LIBEVENT) $(LIBNFSIDMAP) ../../support/nfs/libnfs.a > +idmapd_LDADD = ../../support/nfs/libnfs.a $(LIBEVENT) $(LIBNFSIDMAP) > > MAINTAINERCLEANFILES = Makefile.in > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/utils/idmapd/Makefile.am b/utils/idmapd/Makefile.am index c2f8ba1..1e8e9e6 100644 --- a/utils/idmapd/Makefile.am +++ b/utils/idmapd/Makefile.am @@ -15,7 +15,7 @@ idmapd_SOURCES = \ nfs_idmap.h \ queue.h -idmapd_LDADD = $(LIBEVENT) $(LIBNFSIDMAP) ../../support/nfs/libnfs.a +idmapd_LDADD = ../../support/nfs/libnfs.a $(LIBEVENT) $(LIBNFSIDMAP) MAINTAINERCLEANFILES = Makefile.in
nfs-utils and libnfsidmap have similar configuration parsing routines. They were the same up until nfs-utils commit 7b33590f (config: Remove the conf_path global), where conf_init() was changed to take a path as an argument. With the current idmap_LDADD ordering in Makefile.am, the conf_init() from libnfsidmap is called, resulting in the following error along with the failure to parse idmapd.conf: rpc.idmapd[391]: rpc.idmapd: conf_reinit: open ("(null)", O_RDONLY) failed Placing libnfs.a first in idmap_LDADD ensures that idmapd uses the config parsing routines from nfs-utils instead of libnfsidmap. Signed-off-by: Scott Mayhew <smayhew@redhat.com> --- utils/idmapd/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)