diff mbox

[v4,11/11] arm: enable XENFEAT_ARM_SMCCC_supported feature

Message ID 1503347275-13039-12-git-send-email-volodymyr_babchuk@epam.com (mailing list archive)
State New, archived
Headers show

Commit Message

Volodymyr Babchuk Aug. 21, 2017, 8:27 p.m. UTC
As Xen now supports SMCCC, we can enable this feature to tell
guests that it is safe to call generic SMCs and HVCs.

Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
---
 xen/common/kernel.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jan Beulich Aug. 22, 2017, 7:29 a.m. UTC | #1
>>> On 21.08.17 at 22:27, <volodymyr_babchuk@epam.com> wrote:
> As Xen now supports SMCCC, we can enable this feature to tell
> guests that it is safe to call generic SMCs and HVCs.

I think this and patch 10 should be folded.

> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> ---
>  xen/common/kernel.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/xen/common/kernel.c b/xen/common/kernel.c
> index ce7cb8a..18c4d51 100644
> --- a/xen/common/kernel.c
> +++ b/xen/common/kernel.c
> @@ -332,6 +332,9 @@ DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>                      (1U << XENFEAT_auto_translated_physmap);
>              if ( is_hardware_domain(d) )
>                  fi.submap |= 1U << XENFEAT_dom0;
> +#ifdef CONFIG_ARM
> +            fi.submap |= (1U << XENFEAT_ARM_SMCCC_supported);
> +#endif

Pointless parentheses (as other code in context shows you).

With both aspects taken care of
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan
Julien Grall Aug. 24, 2017, 5:23 p.m. UTC | #2
On 22/08/17 08:29, Jan Beulich wrote:
>>>> On 21.08.17 at 22:27, <volodymyr_babchuk@epam.com> wrote:
>> As Xen now supports SMCCC, we can enable this feature to tell
>> guests that it is safe to call generic SMCs and HVCs.
>
> I think this and patch 10 should be folded.

+1.

>
>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>> ---
>>  xen/common/kernel.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/xen/common/kernel.c b/xen/common/kernel.c
>> index ce7cb8a..18c4d51 100644
>> --- a/xen/common/kernel.c
>> +++ b/xen/common/kernel.c
>> @@ -332,6 +332,9 @@ DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>>                      (1U << XENFEAT_auto_translated_physmap);
>>              if ( is_hardware_domain(d) )
>>                  fi.submap |= 1U << XENFEAT_dom0;
>> +#ifdef CONFIG_ARM
>> +            fi.submap |= (1U << XENFEAT_ARM_SMCCC_supported);
>> +#endif
>
> Pointless parentheses (as other code in context shows you).
>
> With both aspects taken care of
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> Jan
>
diff mbox

Patch

diff --git a/xen/common/kernel.c b/xen/common/kernel.c
index ce7cb8a..18c4d51 100644
--- a/xen/common/kernel.c
+++ b/xen/common/kernel.c
@@ -332,6 +332,9 @@  DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
                     (1U << XENFEAT_auto_translated_physmap);
             if ( is_hardware_domain(d) )
                 fi.submap |= 1U << XENFEAT_dom0;
+#ifdef CONFIG_ARM
+            fi.submap |= (1U << XENFEAT_ARM_SMCCC_supported);
+#endif
 #ifdef CONFIG_X86
             switch ( d->guest_type )
             {