diff mbox

[071/102] remoteproc/keystone: explicitly request exclusive reset control

Message ID 20170719152646.25903-72-p.zabel@pengutronix.de (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Philipp Zabel July 19, 2017, 3:26 p.m. UTC
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.

No functional changes.

Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-remoteproc@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/remoteproc/keystone_remoteproc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Suman Anna July 19, 2017, 4:59 p.m. UTC | #1
On 07/19/2017 10:26 AM, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
> 
> No functional changes.
> 
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: linux-remoteproc@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Acked-by: Suman Anna <s-anna@ti.com>

> ---
>  drivers/remoteproc/keystone_remoteproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
> index 5f776bfd674a0..920fef072b364 100644
> --- a/drivers/remoteproc/keystone_remoteproc.c
> +++ b/drivers/remoteproc/keystone_remoteproc.c
> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto free_rproc;
>  
> -	ksproc->reset = devm_reset_control_get(dev, NULL);
> +	ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
>  	if (IS_ERR(ksproc->reset)) {
>  		ret = PTR_ERR(ksproc->reset);
>  		goto free_rproc;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Suman Anna Aug. 24, 2017, 9:58 p.m. UTC | #2
Hi Bjorn,

On 07/19/2017 11:59 AM, Suman Anna wrote:
> On 07/19/2017 10:26 AM, Philipp Zabel wrote:
>> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
>> reset lines") started to transition the reset control request API calls
>> to explicitly state whether the driver needs exclusive or shared reset
>> control behavior. Convert all drivers requesting exclusive resets to the
>> explicit API call so the temporary transition helpers can be removed.
>>
>> No functional changes.
>>
>> Cc: Ohad Ben-Cohen <ohad@wizery.com>
>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Cc: linux-remoteproc@vger.kernel.org
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> 
> Acked-by: Suman Anna <s-anna@ti.com>

Can you pick this one and the other 2 related remoteproc patches?
Believe the subsystem maintainers have been picking these up, I see some
of the other related patches in linux-next but not these.

regards
Suman

> 
>> ---
>>  drivers/remoteproc/keystone_remoteproc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
>> index 5f776bfd674a0..920fef072b364 100644
>> --- a/drivers/remoteproc/keystone_remoteproc.c
>> +++ b/drivers/remoteproc/keystone_remoteproc.c
>> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
>>  	if (ret)
>>  		goto free_rproc;
>>  
>> -	ksproc->reset = devm_reset_control_get(dev, NULL);
>> +	ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
>>  	if (IS_ERR(ksproc->reset)) {
>>  		ret = PTR_ERR(ksproc->reset);
>>  		goto free_rproc;
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
index 5f776bfd674a0..920fef072b364 100644
--- a/drivers/remoteproc/keystone_remoteproc.c
+++ b/drivers/remoteproc/keystone_remoteproc.c
@@ -410,7 +410,7 @@  static int keystone_rproc_probe(struct platform_device *pdev)
 	if (ret)
 		goto free_rproc;
 
-	ksproc->reset = devm_reset_control_get(dev, NULL);
+	ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
 	if (IS_ERR(ksproc->reset)) {
 		ret = PTR_ERR(ksproc->reset);
 		goto free_rproc;