diff mbox

[ndctl,2/4] allow ND_CMD_CALL for bus

Message ID 20170818133430.8EB1.E1E9C6FF@jp.fujitsu.com (mailing list archive)
State Accepted
Commit bbeba428ead4
Headers show

Commit Message

Gotou, Yasunori/五島 康文 Aug. 18, 2017, 4:34 a.m. UTC 
Currently ndctl supports ND_CMD_CALL only for DIMM,
but Translate SPA is the feature of bus.
So ND_CMD_CALL must be allowed bus's ioctl().


Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
---
 ndctl/lib/libndctl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Dan Williams Aug. 25, 2017, 11:46 p.m. UTC | #1 
On Thu, Aug 17, 2017 at 9:34 PM, Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
>
> Currently ndctl supports ND_CMD_CALL only for DIMM,
> but Translate SPA is the feature of bus.
> So ND_CMD_CALL must be allowed bus's ioctl().
>
>
> Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
> ---
>  ndctl/lib/libndctl.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
> index 93692e5..b3535f0 100644
> --- a/ndctl/lib/libndctl.c
> +++ b/ndctl/lib/libndctl.c
> @@ -2330,6 +2330,7 @@ static int to_ioctl_cmd(int cmd, int dimm)
>  #ifdef HAVE_NDCTL_CLEAR_ERROR
>                 case ND_CMD_CLEAR_ERROR:     return ND_IOCTL_CLEAR_ERROR;
>  #endif
> +               case ND_CMD_CALL:            return ND_IOCTL_CALL;
>                 default:
>                                                        return 0;
>                 };
>

Looks good.
diff mbox

Patch

diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
index 93692e5..b3535f0 100644
--- a/ndctl/lib/libndctl.c
+++ b/ndctl/lib/libndctl.c
@@ -2330,6 +2330,7 @@  static int to_ioctl_cmd(int cmd, int dimm)
 #ifdef HAVE_NDCTL_CLEAR_ERROR
 		case ND_CMD_CLEAR_ERROR:     return ND_IOCTL_CLEAR_ERROR;
 #endif
+		case ND_CMD_CALL:            return ND_IOCTL_CALL;
 		default:
 						       return 0;
 		};