| Message ID | 1503315792-14837-2-git-send-email-bhumirks@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Monday, August 21, 2017 1:43:07 PM CEST Bhumika Goyal wrote: > Make these const as they are only passed as an argument to the function > device_create_file and device_remove_file and the corresponding > arguments are of type const. > Done using Coccinelle > > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> > --- > drivers/acpi/battery.c | 2 +- > drivers/acpi/sbs.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c > index 1cbb88d..13e7b56 100644 > --- a/drivers/acpi/battery.c > +++ b/drivers/acpi/battery.c > @@ -620,7 +620,7 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, > return count; > } > > -static struct device_attribute alarm_attr = { > +static const struct device_attribute alarm_attr = { > .attr = {.name = "alarm", .mode = 0644}, > .show = acpi_battery_alarm_show, > .store = acpi_battery_alarm_store, > diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c > index a184637..a2428e9 100644 > --- a/drivers/acpi/sbs.c > +++ b/drivers/acpi/sbs.c > @@ -474,7 +474,7 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, > return count; > } > > -static struct device_attribute alarm_attr = { > +static const struct device_attribute alarm_attr = { > .attr = {.name = "alarm", .mode = 0644}, > .show = acpi_battery_alarm_show, > .store = acpi_battery_alarm_store, > Applied, thanks!
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 1cbb88d..13e7b56 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -620,7 +620,7 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, return count; } -static struct device_attribute alarm_attr = { +static const struct device_attribute alarm_attr = { .attr = {.name = "alarm", .mode = 0644}, .show = acpi_battery_alarm_show, .store = acpi_battery_alarm_store, diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c index a184637..a2428e9 100644 --- a/drivers/acpi/sbs.c +++ b/drivers/acpi/sbs.c @@ -474,7 +474,7 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, return count; } -static struct device_attribute alarm_attr = { +static const struct device_attribute alarm_attr = { .attr = {.name = "alarm", .mode = 0644}, .show = acpi_battery_alarm_show, .store = acpi_battery_alarm_store,
Make these const as they are only passed as an argument to the function device_create_file and device_remove_file and the corresponding arguments are of type const. Done using Coccinelle Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> --- drivers/acpi/battery.c | 2 +- drivers/acpi/sbs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)