| Message ID | 1504087051-5449-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Geert, Thank you for the patch. On Wednesday, 30 August 2017 12:57:31 EEST Geert Uytterhoeven wrote: > Use the preferred generic node name in the example. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/media/renesas,vsp1.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt > b/Documentation/devicetree/bindings/media/renesas,vsp1.txt index > 9b695bcbf2190bdd..16427017cb45561e 100644 > --- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt > +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.txt > @@ -22,7 +22,7 @@ Optional properties: > > Example: R8A7790 (R-Car H2) VSP1-S node > > - vsp1@fe928000 { > + vsp@fe928000 { vsp1 isn't an instance name but an IP core name. > compatible = "renesas,vsp1"; > reg = <0 0xfe928000 0 0x8000>; > interrupts = <0 267 IRQ_TYPE_LEVEL_HIGH>;
Hi Laurent, On Wed, Aug 30, 2017 at 12:10 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Wednesday, 30 August 2017 12:57:31 EEST Geert Uytterhoeven wrote: >> Use the preferred generic node name in the example. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> --- >> Documentation/devicetree/bindings/media/renesas,vsp1.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt >> b/Documentation/devicetree/bindings/media/renesas,vsp1.txt index >> 9b695bcbf2190bdd..16427017cb45561e 100644 >> --- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt >> +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.txt >> @@ -22,7 +22,7 @@ Optional properties: >> >> Example: R8A7790 (R-Car H2) VSP1-S node >> >> - vsp1@fe928000 { >> + vsp@fe928000 { > > vsp1 isn't an instance name but an IP core name. I know (cfr. "preferred generic node name", not "numerical suffix"). For the actual DTSes on R-Car Gen3, we settled on the more generic "vsp" for the vsp2 node names. R-Car Gen2 DTSes still use "vsp1". >> compatible = "renesas,vsp1"; >> reg = <0 0xfe928000 0 0x8000>; >> interrupts = <0 267 IRQ_TYPE_LEVEL_HIGH>; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wed, Aug 30, 2017 at 11:57:31AM +0200, Geert Uytterhoeven wrote: > Use the preferred generic node name in the example. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Documentation/devicetree/bindings/media/renesas,vsp1.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Rob
diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt b/Documentation/devicetree/bindings/media/renesas,vsp1.txt index 9b695bcbf2190bdd..16427017cb45561e 100644 --- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.txt @@ -22,7 +22,7 @@ Optional properties: Example: R8A7790 (R-Car H2) VSP1-S node - vsp1@fe928000 { + vsp@fe928000 { compatible = "renesas,vsp1"; reg = <0 0xfe928000 0 0x8000>; interrupts = <0 267 IRQ_TYPE_LEVEL_HIGH>;
Use the preferred generic node name in the example. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Documentation/devicetree/bindings/media/renesas,vsp1.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)