| Message ID | 20170824045227.15504-4-jeffy.chen@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Jeffy, Am Donnerstag, 24. August 2017, 12:52:23 CEST schrieb Jeffy Chen: > Currently the rt5514 i2c driver and rt5514 spi driver are using the same > compatible string. > > Add additional unused compatible strings to identify them for Gru > boards. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > --- > > Changes in v7: None > Changes in v6: None > Changes in v3: None > Changes in v2: None > > arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi > b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi index > 5772c52fbfd3..50fb11ad9f17 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi > @@ -611,7 +611,7 @@ ap_i2c_mic: &i2c1 { > i2c-scl-rising-time-ns = <300>; > > headsetcodec: rt5514@57 { > - compatible = "realtek,rt5514"; > + compatible = "realtek,rt5514", "realtek,rt5514-i2c"; the rt5514-i2c and -spi compatibles should be documented in the binding-txt of the chip, but I haven't found any mention of this. Heiko
Hi Heiko, thanks for your reply. On 08/30/2017 09:30 PM, Heiko Stübner wrote: >> >- compatible = "realtek,rt5514"; >> >+ compatible = "realtek,rt5514", "realtek,rt5514-i2c"; > the rt5514-i2c and -spi compatibles should be documented in the binding-txt > of the chip, but I haven't found any mention of this. > > > Heiko these compatibles are only used for our snd driver to detect rt5514 i2c driver and rt5514 spi driver, suggested by Matthias at https://patchwork.kernel.org/patch/9904731/ should i add it in the rockchip,rk3399-gru-sound.txt or rt5514 binding document?
Am Donnerstag, 31. August 2017, 01:00:44 CEST schrieb jeffy: > On 08/30/2017 09:30 PM, Heiko Stübner wrote: > >> >- compatible = "realtek,rt5514"; > >> >+ compatible = "realtek,rt5514", "realtek,rt5514-i2c"; > > > > the rt5514-i2c and -spi compatibles should be documented in the > > binding-txt > > of the chip, but I haven't found any mention of this. > > > > > > Heiko > > these compatibles are only used for our snd driver to detect rt5514 i2c > driver and rt5514 spi driver, suggested by Matthias at > https://patchwork.kernel.org/patch/9904731/ > > should i add it in the rockchip,rk3399-gru-sound.txt or rt5514 binding > document? You're introducing new bindings for the codec, so they should of course part of the rt5514 binding. Heiko
Hi Heiko, On 09/05/2017 06:33 AM, Heiko Stübner wrote: > Am Donnerstag, 31. August 2017, 01:00:44 CEST schrieb jeffy: >> On 08/30/2017 09:30 PM, Heiko Stübner wrote: >>>>> - compatible = "realtek,rt5514"; >>>>> + compatible = "realtek,rt5514", "realtek,rt5514-i2c"; >>> >>> the rt5514-i2c and -spi compatibles should be documented in the >>> binding-txt >>> of the chip, but I haven't found any mention of this. >>> >>> >>> Heiko >> >> these compatibles are only used for our snd driver to detect rt5514 i2c >> driver and rt5514 spi driver, suggested by Matthias at >> https://patchwork.kernel.org/patch/9904731/ >> >> should i add it in the rockchip,rk3399-gru-sound.txt or rt5514 binding >> document? > > You're introducing new bindings for the codec, so they should of course > part of the rt5514 binding. ok, will do that. and it looks like there's no binding for rt5514-spi, will add it too :) > > > Heiko > > > >
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi index 5772c52fbfd3..50fb11ad9f17 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi @@ -611,7 +611,7 @@ ap_i2c_mic: &i2c1 { i2c-scl-rising-time-ns = <300>; headsetcodec: rt5514@57 { - compatible = "realtek,rt5514"; + compatible = "realtek,rt5514", "realtek,rt5514-i2c"; reg = <0x57>; realtek,dmic-init-delay-ms = <20>; }; @@ -820,7 +820,7 @@ ap_i2c_audio: &i2c8 { status = "okay"; wacky_spi_audio: spi2@0 { - compatible = "realtek,rt5514"; + compatible = "realtek,rt5514", "realtek,rt5514-spi"; reg = <0>; interrupt-parent = <&gpio1>; interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional unused compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> --- Changes in v7: None Changes in v6: None Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)