| Message ID | 1505126027-1704-1-git-send-email-mihajlov@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/11/2017 12:33 PM, Viktor Mihajlovski wrote: > Setting the client architecture DHCP option to 0x001f (s390 Basic) [1] > allows the DHCP server to return a s390-specific bootfile if wanted. > DHCP servers not configured for the option (or not yet recognizing the > option value) will continue to work as they have done before. > > [1] https://www.iana.org/assignments/dhcpv6-parameters > > Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> Adding Cornelia. Conny as you have pending patches anyway, I assume you can pick this up. Would be good if Thomas could give his Ack, though. > --- > pc-bios/s390-ccw/netboot.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pc-bios/s390-ccw/netboot.mak b/pc-bios/s390-ccw/netboot.mak > index a9e1374..a25d238 100644 > --- a/pc-bios/s390-ccw/netboot.mak > +++ b/pc-bios/s390-ccw/netboot.mak > @@ -50,7 +50,7 @@ libc.a: $(LIBCOBJS) > > LIBNETOBJS := args.o dhcp.o dns.o icmpv6.o ipv6.o tcp.o udp.o bootp.o \ > dhcpv6.o ethernet.o ipv4.o ndp.o tftp.o > -LIBNETCFLAGS := $(QEMU_CFLAGS) $(LIBC_INC) $(LIBNET_INC) > +LIBNETCFLAGS := $(QEMU_CFLAGS) -DDHCPARCH=0x1F $(LIBC_INC) $(LIBNET_INC) > > %.o : $(SLOF_DIR)/lib/libnet/%.c > $(call quiet-command,$(CC) $(LIBNETCFLAGS) -c -o $@ $<,"CC","$(TARGET_DIR)$@") >
On 11.09.2017 12:33, Viktor Mihajlovski wrote: > Setting the client architecture DHCP option to 0x001f (s390 Basic) [1] > allows the DHCP server to return a s390-specific bootfile if wanted. > DHCP servers not configured for the option (or not yet recognizing the > option value) will continue to work as they have done before. > > [1] https://www.iana.org/assignments/dhcpv6-parameters Ah, nice, you already registered a value for s390x :-) May I ask what's the difference between "Basic" and "Extended" there? > Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> > --- > pc-bios/s390-ccw/netboot.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pc-bios/s390-ccw/netboot.mak b/pc-bios/s390-ccw/netboot.mak > index a9e1374..a25d238 100644 > --- a/pc-bios/s390-ccw/netboot.mak > +++ b/pc-bios/s390-ccw/netboot.mak > @@ -50,7 +50,7 @@ libc.a: $(LIBCOBJS) > > LIBNETOBJS := args.o dhcp.o dns.o icmpv6.o ipv6.o tcp.o udp.o bootp.o \ > dhcpv6.o ethernet.o ipv4.o ndp.o tftp.o > -LIBNETCFLAGS := $(QEMU_CFLAGS) $(LIBC_INC) $(LIBNET_INC) > +LIBNETCFLAGS := $(QEMU_CFLAGS) -DDHCPARCH=0x1F $(LIBC_INC) $(LIBNET_INC) > > %.o : $(SLOF_DIR)/lib/libnet/%.c > $(call quiet-command,$(CC) $(LIBNETCFLAGS) -c -o $@ $<,"CC","$(TARGET_DIR)$@") > Reviewed-by: Thomas Huth <thuth@redhat.com>
On 11.09.2017 15:58, Thomas Huth wrote: > On 11.09.2017 12:33, Viktor Mihajlovski wrote: >> Setting the client architecture DHCP option to 0x001f (s390 Basic) [1] >> allows the DHCP server to return a s390-specific bootfile if wanted. >> DHCP servers not configured for the option (or not yet recognizing the >> option value) will continue to work as they have done before. >> >> [1] https://www.iana.org/assignments/dhcpv6-parameters > > Ah, nice, you already registered a value for s390x :-) > May I ask what's the difference between "Basic" and "Extended" there? > sure, "Basic" stands for the "classic netboot", i.e. a single binary file is designated by the bootfile in the DHCP reply. "Extended" is the mode implemented by Dynamic Partition Manager, where the bootfile is some sort of configuration file. [...]
On Mon, 11 Sep 2017 12:33:47 +0200 Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> wrote: > Setting the client architecture DHCP option to 0x001f (s390 Basic) [1] > allows the DHCP server to return a s390-specific bootfile if wanted. > DHCP servers not configured for the option (or not yet recognizing the > option value) will continue to work as they have done before. > > [1] https://www.iana.org/assignments/dhcpv6-parameters > > Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> > --- > pc-bios/s390-ccw/netboot.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pc-bios/s390-ccw/netboot.mak b/pc-bios/s390-ccw/netboot.mak > index a9e1374..a25d238 100644 > --- a/pc-bios/s390-ccw/netboot.mak > +++ b/pc-bios/s390-ccw/netboot.mak > @@ -50,7 +50,7 @@ libc.a: $(LIBCOBJS) > > LIBNETOBJS := args.o dhcp.o dns.o icmpv6.o ipv6.o tcp.o udp.o bootp.o \ > dhcpv6.o ethernet.o ipv4.o ndp.o tftp.o > -LIBNETCFLAGS := $(QEMU_CFLAGS) $(LIBC_INC) $(LIBNET_INC) > +LIBNETCFLAGS := $(QEMU_CFLAGS) -DDHCPARCH=0x1F $(LIBC_INC) $(LIBNET_INC) > > %.o : $(SLOF_DIR)/lib/libnet/%.c > $(call quiet-command,$(CC) $(LIBNETCFLAGS) -c -o $@ $<,"CC","$(TARGET_DIR)$@") Thanks, applied.
diff --git a/pc-bios/s390-ccw/netboot.mak b/pc-bios/s390-ccw/netboot.mak index a9e1374..a25d238 100644 --- a/pc-bios/s390-ccw/netboot.mak +++ b/pc-bios/s390-ccw/netboot.mak @@ -50,7 +50,7 @@ libc.a: $(LIBCOBJS) LIBNETOBJS := args.o dhcp.o dns.o icmpv6.o ipv6.o tcp.o udp.o bootp.o \ dhcpv6.o ethernet.o ipv4.o ndp.o tftp.o -LIBNETCFLAGS := $(QEMU_CFLAGS) $(LIBC_INC) $(LIBNET_INC) +LIBNETCFLAGS := $(QEMU_CFLAGS) -DDHCPARCH=0x1F $(LIBC_INC) $(LIBNET_INC) %.o : $(SLOF_DIR)/lib/libnet/%.c $(call quiet-command,$(CC) $(LIBNETCFLAGS) -c -o $@ $<,"CC","$(TARGET_DIR)$@")
Setting the client architecture DHCP option to 0x001f (s390 Basic) [1] allows the DHCP server to return a s390-specific bootfile if wanted. DHCP servers not configured for the option (or not yet recognizing the option value) will continue to work as they have done before. [1] https://www.iana.org/assignments/dhcpv6-parameters Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> --- pc-bios/s390-ccw/netboot.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)