| Message ID | 1505409850-6468-1-git-send-email-zhi.a.wang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
well, I wouldn't call this as a typo.
This is a logic fix and deserves a better subject a proper
commit message an also fixes tag:
Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
On Thu, Sep 14, 2017 at 05:24:09PM +0000, Zhi Wang wrote:
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 729ebaf..37cd086 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst)
> };
>
> /* Cache attribute has to be matched. */
> - if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst))
> + if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst))
> return 0;
>
> score |= CA_MATCH;
> --
> 2.7.4
>
Thanks for the comments. V2 has been sent. -----Original Message----- From: Vivi, Rodrigo Sent: Thursday, September 14, 2017 8:37 PM To: Wang, Zhi A <zhi.a.wang@intel.com> Cc: intel-gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org; joonas.lahtinen@linux.intel.com; chris@chris-wilson.co.uk; zhenyuw@linux.intel.com; Widawsky, Benjamin <benjamin.widawsky@intel.com> Subject: Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get() well, I wouldn't call this as a typo. This is a logic fix and deserves a better subject a proper commit message an also fixes tag: Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management") On Thu, Sep 14, 2017 at 05:24:09PM +0000, Zhi Wang wrote: > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Ben Widawsky <benjamin.widawsky@intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Signed-off-by: Zhi Wang <zhi.a.wang@intel.com> > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c > b/drivers/gpu/drm/i915/i915_gem_gtt.c > index 729ebaf..37cd086 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst) > }; > > /* Cache attribute has to be matched. */ > - if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst)) > + if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst)) > return 0; > > score |= CA_MATCH; > -- > 2.7.4 >
Quoting Rodrigo Vivi (2017-09-14 18:36:49) > > well, I wouldn't call this as a typo. > This is a logic fix and deserves a better subject a proper > commit message an also fixes tag: It should work either way, just the bug doesn't allow reuse. The question to ask is why didn't the selftest pick this up? It passes on bdw... -Chris
On Thu, 2017-09-14 at 17:51 +0000, Wang, Zhi A wrote:
> Thanks for the comments. V2 has been sent.
At least I never received V2, so the fix has still not been merged.
Please (re-)send it ASAP.
Regards, Joonas
Sorry I changed the tittle of the patch with a fixes line. You have already given an r-b. :) -----Original Message----- From: Joonas Lahtinen [mailto:joonas.lahtinen@linux.intel.com] Sent: Monday, September 18, 2017 4:08 PM To: Wang, Zhi A <zhi.a.wang@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com> Cc: intel-gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org; chris@chris-wilson.co.uk; zhenyuw@linux.intel.com; Widawsky, Benjamin <benjamin.widawsky@intel.com> Subject: Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get() On Thu, 2017-09-14 at 17:51 +0000, Wang, Zhi A wrote: > Thanks for the comments. V2 has been sent. At least I never received V2, so the fix has still not been merged. Please (re-)send it ASAP. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 729ebaf..37cd086 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst) }; /* Cache attribute has to be matched. */ - if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst)) + if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst)) return 0; score |= CA_MATCH;
Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Ben Widawsky <benjamin.widawsky@intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)