| Message ID | 20170919103724.GA239@x4 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote: > Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from > internal superblock flags") the lazytime mount option didn't get passed > on anymore. > > Fix the issue by handling the option in do_mount(). > > Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de> > --- > fs/namespace.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/namespace.c b/fs/namespace.c > index 54059b142d6b..b633838b8f02 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name, > SB_MANDLOCK | > SB_DIRSYNC | > SB_SILENT | > - SB_POSIXACL); > + SB_POSIXACL | > + SB_LAZYTIME); Looks good. Although I still think that this can be per mountpoint options. Regardless of that, you can add Reviewed-by: Lukas Czerner <lczerner@redhat.com> > > if (flags & MS_REMOUNT) > retval = do_remount(&path, flags, sb_flags, mnt_flags, > -- > Markus
On 2017.09.19 at 17:25 +0200, Lukas Czerner wrote: > On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote: > > Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from > > internal superblock flags") the lazytime mount option didn't get passed > > on anymore. > > > > Fix the issue by handling the option in do_mount(). > > > > Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de> > > --- > > fs/namespace.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/fs/namespace.c b/fs/namespace.c > > index 54059b142d6b..b633838b8f02 100644 > > --- a/fs/namespace.c > > +++ b/fs/namespace.c > > @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name, > > SB_MANDLOCK | > > SB_DIRSYNC | > > SB_SILENT | > > - SB_POSIXACL); > > + SB_POSIXACL | > > + SB_LAZYTIME); > > Looks good. Although I still think that this can be per mountpoint options. > > Regardless of that, you can add > Reviewed-by: Lukas Czerner <lczerner@redhat.com> Ping? Al could you please take look? Thanks.
diff --git a/fs/namespace.c b/fs/namespace.c index 54059b142d6b..b633838b8f02 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name, SB_MANDLOCK | SB_DIRSYNC | SB_SILENT | - SB_POSIXACL); + SB_POSIXACL | + SB_LAZYTIME); if (flags & MS_REMOUNT) retval = do_remount(&path, flags, sb_flags, mnt_flags,
Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from internal superblock flags") the lazytime mount option didn't get passed on anymore. Fix the issue by handling the option in do_mount(). Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de> --- fs/namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)