| Message ID | 1505750174-29888-1-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 829e4887b8676255778e162efc57e4a0f18f8bb3 |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Ulrich, Thank you for the patch. On Monday, 18 September 2017 18:56:14 EEST Ulrich Hecht wrote: > This fixes the warning "pwm-backlight backlight: backlight supply power > not found, using dummy regulator". > > Fixes: b33be33670217533 ("arm64: dts: salvator-x: Add panel backlight > support") > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > --- > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index e3d8310..fa2a1f7 > 100644 > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > @@ -63,6 +63,7 @@ > brightness-levels = <256 128 64 16 8 4 0>; > default-brightness-level = <6>; > > + power-supply = <®_12v>; > enable-gpios = <&gpio6 7 GPIO_ACTIVE_HIGH>; > }; > > @@ -107,6 +108,15 @@ > regulator-always-on; > }; > > + reg_12v: regulator2 { Nitpicking, should be call this reg_12p0v to match the naming scheme of the other fixed regulators ? Apart from that, and regardless of whether you want to change the name or not, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + compatible = "regulator-fixed"; > + regulator-name = "fixed-12V"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > rsnd_ak4613: sound { > compatible = "simple-audio-card";
On Mon, Sep 18, 2017 at 5:56 PM, Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote: > This fixes the warning "pwm-backlight backlight: backlight supply power > not found, using dummy regulator". > > Fixes: b33be33670217533 ("arm64: dts: salvator-x: Add panel backlight support") > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wed, Sep 20, 2017 at 01:55:09PM +0200, Geert Uytterhoeven wrote: > On Mon, Sep 18, 2017 at 5:56 PM, Ulrich Hecht > <ulrich.hecht+renesas@gmail.com> wrote: > > This fixes the warning "pwm-backlight backlight: backlight supply power > > not found, using dummy regulator". > > > > Fixes: b33be33670217533 ("arm64: dts: salvator-x: Add panel backlight support") > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, applied as a fix for v4.14.
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index e3d8310..fa2a1f7 100644 --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi @@ -63,6 +63,7 @@ brightness-levels = <256 128 64 16 8 4 0>; default-brightness-level = <6>; + power-supply = <®_12v>; enable-gpios = <&gpio6 7 GPIO_ACTIVE_HIGH>; }; @@ -107,6 +108,15 @@ regulator-always-on; }; + reg_12v: regulator2 { + compatible = "regulator-fixed"; + regulator-name = "fixed-12V"; + regulator-min-microvolt = <12000000>; + regulator-max-microvolt = <12000000>; + regulator-boot-on; + regulator-always-on; + }; + rsnd_ak4613: sound { compatible = "simple-audio-card";
This fixes the warning "pwm-backlight backlight: backlight supply power not found, using dummy regulator". Fixes: b33be33670217533 ("arm64: dts: salvator-x: Add panel backlight support") Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> --- arch/arm64/boot/dts/renesas/salvator-common.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)