diff mbox

build: propagate runstatedir

Message ID 20170913085232.6516-1-wei.liu2@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Liu Sept. 13, 2017, 8:52 a.m. UTC
Debian Stretch's autoconf has a new variable called runstatedir. Add
that to Paths.mk.in.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 config/Paths.mk.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Jürgen Groß Sept. 13, 2017, 9:07 a.m. UTC | #1
On 13/09/17 10:52, Wei Liu wrote:
> Debian Stretch's autoconf has a new variable called runstatedir. Add
> that to Paths.mk.in.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

You did think of

https://lists.xen.org/archives/html/xen-devel/2017-02/msg01883.html

I suppose?


Juergen

> ---
>  config/Paths.mk.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/config/Paths.mk.in b/config/Paths.mk.in
> index a603295146..660b515121 100644
> --- a/config/Paths.mk.in
> +++ b/config/Paths.mk.in
> @@ -28,6 +28,7 @@ psdir                    := @psdir@
>  includedir               := @includedir@
>  localstatedir            := @localstatedir@
>  sysconfdir               := @sysconfdir@
> +runstatedir              := @runstatedir@
>  
>  LIBEXEC                  := @LIBEXEC@
>  LIBEXEC_BIN              := @LIBEXEC_BIN@
>
Wei Liu Sept. 13, 2017, 9:11 a.m. UTC | #2
On Wed, Sep 13, 2017 at 11:07:15AM +0200, Juergen Gross wrote:
> On 13/09/17 10:52, Wei Liu wrote:
> > Debian Stretch's autoconf has a new variable called runstatedir. Add
> > that to Paths.mk.in.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> You did think of
> 
> https://lists.xen.org/archives/html/xen-devel/2017-02/msg01883.html
> 
> I suppose?
> 

Yes. That was added at a time when autoconf didn't have runstatedir
iirc. Now autoconf has that. There is no reason not to propagate it.
Wei Liu Sept. 20, 2017, 3:09 p.m. UTC | #3
On Wed, Sep 13, 2017 at 10:11:25AM +0100, Wei Liu wrote:
> On Wed, Sep 13, 2017 at 11:07:15AM +0200, Juergen Gross wrote:
> > On 13/09/17 10:52, Wei Liu wrote:
> > > Debian Stretch's autoconf has a new variable called runstatedir. Add
> > > that to Paths.mk.in.
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > 
> > You did think of
> > 
> > https://lists.xen.org/archives/html/xen-devel/2017-02/msg01883.html
> > 
> > I suppose?
> > 
> 
> Yes. That was added at a time when autoconf didn't have runstatedir
> iirc. Now autoconf has that. There is no reason not to propagate it.

Thinking about this a bit more, exposing runstatedir like this doesn't
have much value. I want to make it work with the existing option that we
already have.
diff mbox

Patch

diff --git a/config/Paths.mk.in b/config/Paths.mk.in
index a603295146..660b515121 100644
--- a/config/Paths.mk.in
+++ b/config/Paths.mk.in
@@ -28,6 +28,7 @@  psdir                    := @psdir@
 includedir               := @includedir@
 localstatedir            := @localstatedir@
 sysconfdir               := @sysconfdir@
+runstatedir              := @runstatedir@
 
 LIBEXEC                  := @LIBEXEC@
 LIBEXEC_BIN              := @LIBEXEC_BIN@