| Message ID | 20170922002146.6224-1-radhakrishna.sripada@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> I'll merge this and DK's one you reviewed as soon as I recharge my laptop! :) > On Sep 21, 2017, at 5:19 PM, Sripada, Radhakrishna <radhakrishna.sripada@intel.com> wrote: > > The substring to be matched is "DRRS Supported: Yes" and not > "DRRS Support: No". The kernel prints the DRRS status for all active > CRTC's. Matching for No support gives a false positive when multiple > CRTC's are active. > > Fixes: 33355210a43e (igt/kms_psr_sink_crc: Add psr_drrs subtest) > Cc: C. Ramalingam <ramalingam.c@intel.com> > Cc: Lohith BS <lohith.bs@intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > --- > tests/kms_psr_sink_crc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c > index 1c25f2c81a34..f023b12c0131 100644 > --- a/tests/kms_psr_sink_crc.c > +++ b/tests/kms_psr_sink_crc.c > @@ -290,7 +290,7 @@ static bool drrs_disabled(data_t *data) > > igt_debugfs_read(data->drm_fd, "i915_drrs_status", buf); > > - return strstr(buf, "DRRS Support: No\n"); > + return !strstr(buf, "DRRS Supported: Yes\n"); > } > > static void run_test(data_t *data) > -- > 2.9.3 >
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 1c25f2c81a34..f023b12c0131 100644 --- a/tests/kms_psr_sink_crc.c +++ b/tests/kms_psr_sink_crc.c @@ -290,7 +290,7 @@ static bool drrs_disabled(data_t *data) igt_debugfs_read(data->drm_fd, "i915_drrs_status", buf); - return strstr(buf, "DRRS Support: No\n"); + return !strstr(buf, "DRRS Supported: Yes\n"); } static void run_test(data_t *data)
The substring to be matched is "DRRS Supported: Yes" and not "DRRS Support: No". The kernel prints the DRRS status for all active CRTC's. Matching for No support gives a false positive when multiple CRTC's are active. Fixes: 33355210a43e (igt/kms_psr_sink_crc: Add psr_drrs subtest) Cc: C. Ramalingam <ramalingam.c@intel.com> Cc: Lohith BS <lohith.bs@intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> --- tests/kms_psr_sink_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)