| Message ID | 20170920211505.26171-1-Larry.Finger@lwfinger.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b8b8b16352cd90c6083033fd4487f04fae935c18 |
| Delegated to: | Kalle Valo |
| Headers | show |
Larry Finger <Larry.Finger@lwfinger.net> wrote: > In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read > of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi > this change results in reduced stability for the wireless connection. > This regression was located using bisection. > > Fixes: 40b368af4b75 ("rtlwifi: Fix alignment issues") > Reported-and-tested-by: James Cameron <quozl@laptop.org> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Stable <stable@vger.kernel.org> # 4.11+ > Cc: Ping-Ke Shih <pkshih@realtek.com> Should I queue this for 4.14? (The first commit was v4.11-rc1.)
On 09/25/2017 03:06 AM, Kalle Valo wrote: > Larry Finger <Larry.Finger@lwfinger.net> wrote: > >> In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read >> of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi >> this change results in reduced stability for the wireless connection. >> This regression was located using bisection. >> >> Fixes: 40b368af4b75 ("rtlwifi: Fix alignment issues") >> Reported-and-tested-by: James Cameron <quozl@laptop.org> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> >> Cc: Stable <stable@vger.kernel.org> # 4.11+ >> Cc: Ping-Ke Shih <pkshih@realtek.com> > > Should I queue this for 4.14? > > (The first commit was v4.11-rc1.) Yes, please do. Larry
Larry Finger <Larry.Finger@lwfinger.net> wrote: > In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read > of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi > this change results in reduced stability for the wireless connection. > This regression was located using bisection. > > Fixes: 40b368af4b75 ("rtlwifi: Fix alignment issues") > Reported-and-tested-by: James Cameron <quozl@laptop.org> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Stable <stable@vger.kernel.org> # 4.11+ > Cc: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-drivers.git, thanks. b8b8b16352cd rtlwifi: rtl8821ae: Fix connection lost problem
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c index 3571ce4bd276..ac2ce86de506 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c @@ -1122,7 +1122,7 @@ static u8 _rtl8821ae_dbi_read(struct rtl_priv *rtlpriv, u16 addr) } if (0 == tmp) { read_addr = REG_DBI_RDATA + addr % 4; - ret = rtl_read_byte(rtlpriv, read_addr); + ret = rtl_read_word(rtlpriv, read_addr); } return ret; }
In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi this change results in reduced stability for the wireless connection. This regression was located using bisection. Fixes: 40b368af4b75 ("rtlwifi: Fix alignment issues") Reported-and-tested-by: James Cameron <quozl@laptop.org> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Cc: Stable <stable@vger.kernel.org> # 4.11+ Cc: Ping-Ke Shih <pkshih@realtek.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)