diff mbox

cpufreq: SPEAr: pr_err() strings should end with newlines

Message ID 511e2c0f9a2dd23aceb8c0fc39184bfaca1f98c9.1506334381.git.arvind.yadav.cs@gmail.com (mailing list archive)
State Mainlined
Delegated to: Rafael Wysocki
Headers show

Commit Message

Arvind Yadav Sept. 25, 2017, 10:13 a.m. UTC
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/cpufreq/spear-cpufreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Viresh Kumar Sept. 25, 2017, 11:12 p.m. UTC | #1
On 25-09-17, 15:43, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/cpufreq/spear-cpufreq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c
> index 4894924..195f27f 100644
> --- a/drivers/cpufreq/spear-cpufreq.c
> +++ b/drivers/cpufreq/spear-cpufreq.c
> @@ -177,7 +177,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev)
>  
>  	np = of_cpu_device_node_get(0);
>  	if (!np) {
> -		pr_err("No cpu node found");
> +		pr_err("No cpu node found\n");
>  		return -ENODEV;
>  	}
>  
> @@ -187,7 +187,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev)
>  
>  	prop = of_find_property(np, "cpufreq_tbl", NULL);
>  	if (!prop || !prop->value) {
> -		pr_err("Invalid cpufreq_tbl");
> +		pr_err("Invalid cpufreq_tbl\n");
>  		ret = -ENODEV;
>  		goto out_put_node;
>  	}

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff mbox

Patch

diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c
index 4894924..195f27f 100644
--- a/drivers/cpufreq/spear-cpufreq.c
+++ b/drivers/cpufreq/spear-cpufreq.c
@@ -177,7 +177,7 @@  static int spear_cpufreq_probe(struct platform_device *pdev)
 
 	np = of_cpu_device_node_get(0);
 	if (!np) {
-		pr_err("No cpu node found");
+		pr_err("No cpu node found\n");
 		return -ENODEV;
 	}
 
@@ -187,7 +187,7 @@  static int spear_cpufreq_probe(struct platform_device *pdev)
 
 	prop = of_find_property(np, "cpufreq_tbl", NULL);
 	if (!prop || !prop->value) {
-		pr_err("Invalid cpufreq_tbl");
+		pr_err("Invalid cpufreq_tbl\n");
 		ret = -ENODEV;
 		goto out_put_node;
 	}