[v6,2/4] gitignore: sort src/ binaries name

Commit Message

Murphy Zhou Sept. 28, 2017, 7:41 a.m. UTC

Signed-off-by: Xiong Zhou <[e-mail]>
---
 .gitignore | 50 +++++++++++++++++++++++++-------------------------
 1 file changed, 25 insertions(+), 25 deletions(-)

Comments

Dave Chinner Sept. 28, 2017, 11:10 a.m. UTC | #1

On Thu, Sep 28, 2017 at 03:41:38PM +0800, Xiong Zhou wrote:
> Signed-off-by: Xiong Zhou <[e-mail]>

Why? you're not fixing any problem here, and it's completely
unrelated to fixing the issue the series is about....

Cheers,

Dave.

Murphy Zhou Sept. 28, 2017, 12:28 p.m. UTC | #2

On Thu, Sep 28, 2017 at 09:10:08PM +1000, Dave Chinner wrote:
> On Thu, Sep 28, 2017 at 03:41:38PM +0800, Xiong Zhou wrote:
> > Signed-off-by: Xiong Zhou <[e-mail]>
> 
> Why? you're not fixing any problem here, and it's completely
> unrelated to fixing the issue the series is about....

Yes. It's not related and a little weird. Because I'm too lazy
to split them. This is a "by the way" patch.

If you strongly recommend, I could resend these into 2 series:
one with the fix of fake failures, the other is the write_ro
case with the name/group fixes.

Thanks,
Xiong

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> [e-mail]
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Dave Chinner Sept. 28, 2017, 9:43 p.m. UTC | #3

On Thu, Sep 28, 2017 at 08:28:32PM +0800, Xiong Zhou wrote:
> On Thu, Sep 28, 2017 at 09:10:08PM +1000, Dave Chinner wrote:
> > On Thu, Sep 28, 2017 at 03:41:38PM +0800, Xiong Zhou wrote:
> > > Signed-off-by: Xiong Zhou <[e-mail]>
> > 
> > Why? you're not fixing any problem here, and it's completely
> > unrelated to fixing the issue the series is about....
> 
> Yes. It's not related and a little weird. Because I'm too lazy
> to split them. This is a "by the way" patch.
> 
> If you strongly recommend, I could resend these into 2 series:
> one with the fix of fake failures, the other is the write_ro
> case with the name/group fixes.

Yes, please send them in a separate series - patch series are
supposed to contain related patches. i.e. random changes should
not be added to a set of fixes for a specific problem. Thanks!

Cheers,

Dave.

Patch

diff --git a/.gitignore b/.gitignore
index 63928b4..73ab533 100644
--- a/.gitignore
+++ b/.gitignore
@@ -49,6 +49,19 @@ 
 
 # src/ binaries
 /src/af_unix
+/src/aio-dio-regress/aio-dio-cycle-write
+/src/aio-dio-regress/aio-dio-eof-race
+/src/aio-dio-regress/aio-dio-extend-stat
+/src/aio-dio-regress/aio-dio-fcntl-race
+/src/aio-dio-regress/aio-dio-hole-filling-race
+/src/aio-dio-regress/aio-dio-invalidate-failure
+/src/aio-dio-regress/aio-dio-invalidate-readahead
+/src/aio-dio-regress/aio-dio-subblock-eof-read
+/src/aio-dio-regress/aio-free-ring-with-bogus-nr-pages
+/src/aio-dio-regress/aio-io-setup-with-nonwritable-context-pointer
+/src/aio-dio-regress/aio-last-ref-held-by-io
+/src/aio-dio-regress/aiocp
+/src/aio-dio-regress/aiodio_sparse2
 /src/alloc
 /src/append_reader
 /src/append_writer
@@ -56,10 +69,12 @@ 
 /src/bstat
 /src/bulkstat_unlink_test
 /src/bulkstat_unlink_test_modified
+/src/cloner
 /src/dbtest
 /src/devzero
 /src/dio-interleaved
 /src/dio-invalidate-cache
+/src/dirhash_collide
 /src/dirperf
 /src/dirstress
 /src/dmiperf
@@ -76,7 +91,6 @@ 
 /src/fsync-tester
 /src/ftrunc
 /src/genhashnames
-/src/dirhash_collide
 /src/getdevicesize
 /src/getpagesize
 /src/godown
@@ -85,6 +99,7 @@ 
 /src/itrash
 /src/listxattr
 /src/locktest
+/src/log-writes/replay-log
 /src/loggen
 /src/looptest
 /src/lstat64
@@ -98,11 +113,11 @@ 
 /src/permname
 /src/preallo_rw_pattern_reader
 /src/preallo_rw_pattern_writer
+/src/punch-alternating
 /src/pwrite_mmap_blocked
 /src/randholes
-/src/t_readdir_1
-/src/t_readdir_2
 /src/rename
+/src/renameat2
 /src/resvtest
 /src/runas
 /src/seek_copy_test
@@ -118,8 +133,15 @@ 
 /src/t_getcwd
 /src/t_holes
 /src/t_immutable
+/src/t_mmap_cow_race
+/src/t_mmap_dio
+/src/t_mmap_fallocate
+/src/t_mmap_stale_pmd
 /src/t_mmap_writev
 /src/t_mtab
+/src/t_readdir_1
+/src/t_readdir_2
+/src/t_rename_overwrite
 /src/t_stripealign
 /src/t_truncate_cmtime
 /src/t_truncate_self
@@ -133,28 +155,6 @@ 
 /src/writemod
 /src/writev_on_pagefault
 /src/xfsctl
-/src/aio-dio-regress/aio-dio-cycle-write
-/src/aio-dio-regress/aio-dio-extend-stat
-/src/aio-dio-regress/aio-dio-fcntl-race
-/src/aio-dio-regress/aio-dio-hole-filling-race
-/src/aio-dio-regress/aio-dio-invalidate-failure
-/src/aio-dio-regress/aio-dio-invalidate-readahead
-/src/aio-dio-regress/aio-dio-subblock-eof-read
-/src/aio-dio-regress/aio-free-ring-with-bogus-nr-pages
-/src/aio-dio-regress/aio-io-setup-with-nonwritable-context-pointer
-/src/aio-dio-regress/aio-last-ref-held-by-io
-/src/aio-dio-regress/aiocp
-/src/aio-dio-regress/aiodio_sparse2
-/src/aio-dio-regress/aio-dio-eof-race
-/src/punch-alternating
-/src/cloner
-/src/renameat2
-/src/t_rename_overwrite
-/src/t_mmap_dio
-/src/t_mmap_stale_pmd
-/src/t_mmap_cow_race
-/src/t_mmap_fallocate
-/src/log-writes/replay-log
 
 # dmapi/ binaries
 /dmapi/src/common/cmd/read_invis