diff mbox

input: synaptics-rmi4: make array rmi_f54_report_type_names static

Message ID 20171002220525.11339-1-colin.king@canonical.com (mailing list archive)
State Accepted
Headers show

Commit Message

Colin King Oct. 2, 2017, 10:05 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The array rmi_f54_report_type_names is local to the source and does
not need to be in global scope, so make it static. Also make the array
const char * const

Cleans up sparse warning:
symbol 'rmi_f54_report_type_names' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/input/rmi4/rmi_f54.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guenter Roeck Oct. 2, 2017, 10:18 p.m. UTC | #1 
On Mon, Oct 02, 2017 at 11:05:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The array rmi_f54_report_type_names is local to the source and does
> not need to be in global scope, so make it static. Also make the array
> const char * const
> 
> Cleans up sparse warning:
> symbol 'rmi_f54_report_type_names' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/input/rmi4/rmi_f54.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
> index f5206e2c767e..70f6310f1d15 100644
> --- a/drivers/input/rmi4/rmi_f54.c
> +++ b/drivers/input/rmi4/rmi_f54.c
> @@ -73,7 +73,7 @@ enum rmi_f54_report_type {
>  	F54_MAX_REPORT_TYPE,
>  };
>  
> -const char *rmi_f54_report_type_names[] = {
> +static const char * const rmi_f54_report_type_names[] = {
>  	[F54_REPORT_NONE]		= "Unknown",
>  	[F54_8BIT_IMAGE]		= "Normalized 8-Bit Image",
>  	[F54_16BIT_IMAGE]		= "Normalized 16-Bit Image",
> -- 
> 2.14.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dmitry Torokhov Oct. 5, 2017, midnight UTC | #2 
On Mon, Oct 02, 2017 at 03:18:52PM -0700, Guenter Roeck wrote:
> On Mon, Oct 02, 2017 at 11:05:25PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The array rmi_f54_report_type_names is local to the source and does
> > not need to be in global scope, so make it static. Also make the array
> > const char * const
> > 
> > Cleans up sparse warning:
> > symbol 'rmi_f54_report_type_names' was not declared. Should it be static?
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Applied, thank you.

> 
> > ---
> >  drivers/input/rmi4/rmi_f54.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
> > index f5206e2c767e..70f6310f1d15 100644
> > --- a/drivers/input/rmi4/rmi_f54.c
> > +++ b/drivers/input/rmi4/rmi_f54.c
> > @@ -73,7 +73,7 @@ enum rmi_f54_report_type {
> >  	F54_MAX_REPORT_TYPE,
> >  };
> >  
> > -const char *rmi_f54_report_type_names[] = {
> > +static const char * const rmi_f54_report_type_names[] = {
> >  	[F54_REPORT_NONE]		= "Unknown",
> >  	[F54_8BIT_IMAGE]		= "Normalized 8-Bit Image",
> >  	[F54_16BIT_IMAGE]		= "Normalized 16-Bit Image",
> > -- 
> > 2.14.1
> >
diff mbox

Patch

diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
index f5206e2c767e..70f6310f1d15 100644
--- a/drivers/input/rmi4/rmi_f54.c
+++ b/drivers/input/rmi4/rmi_f54.c
@@ -73,7 +73,7 @@  enum rmi_f54_report_type {
 	F54_MAX_REPORT_TYPE,
 };
 
-const char *rmi_f54_report_type_names[] = {
+static const char * const rmi_f54_report_type_names[] = {
 	[F54_REPORT_NONE]		= "Unknown",
 	[F54_8BIT_IMAGE]		= "Normalized 8-Bit Image",
 	[F54_16BIT_IMAGE]		= "Normalized 16-Bit Image",