diff mbox

ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board

Message ID 20170920144009.GA27374@ingrassia.epigenesys.com (mailing list archive)
State Accepted
Headers show

Commit Message

Emiliano Ingrassia Sept. 20, 2017, 2:40 p.m. UTC
This patch enables the USB Host controller (USB1) and the relative USB2 PHY
on Odroid-C1/C1+ board.

Signed-off-by: Emiliano Ingrassia <ingrassia@epigenesys.com>
---
 arch/arm/boot/dts/meson8b-odroidc1.dts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

Comments

Martin Blumenstingl Sept. 22, 2017, 7:01 a.m. UTC | #1
On Wed, Sep 20, 2017 at 4:40 PM, Emiliano Ingrassia
<ingrassia@epigenesys.com> wrote:
> This patch enables the USB Host controller (USB1) and the relative USB2 PHY
> on Odroid-C1/C1+ board.
>
> Signed-off-by: Emiliano Ingrassia <ingrassia@epigenesys.com>
I don't have any Odroid hardware to play with, but this looks good to me:

Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

> ---
>  arch/arm/boot/dts/meson8b-odroidc1.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> index e50f1a1fdbc7..9ff6ca4e20d0 100644
> --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> @@ -76,3 +76,26 @@
>         pinctrl-0 = <&uart_ao_a_pins>;
>         pinctrl-names = "default";
>  };
> +
> +&gpio_ao {
> +       /*
> +        * WARNING: The USB Hub on the Odroid-C1/C1+ needs a reset signal
> +        * to be turned high in order to be detected by the USB Controller.
> +        * This signal should be handled by a USB specific power sequence
> +        * in order to reset the Hub when USB bus is powered down.
> +        */
> +       usb-hub {
> +               gpio-hog;
> +               gpios = <GPIOAO_4 GPIO_ACTIVE_HIGH>;
> +               output-high;
> +               line-name = "usb-hub-reset";
> +       };
> +};
> +
> +&usb1_phy {
> +       status = "okay";
> +};
> +
> +&usb1 {
> +       status = "okay";
> +};
> --
> 2.14.1
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
Linus Lüssing Sept. 28, 2017, 4:44 p.m. UTC | #2
> This patch enables the USB Host controller (USB1) and the relative USB2 PHY
> on Odroid-C1/C1+ board.
> 
> Signed-off-by: Emiliano Ingrassia <ingrassia@epigenesys.com>

As the freezes seems to be caused by something else and stress-ng works
fine for me now on an Odroid C1+ (at least with the reserved
memory regions):

Tested-by: Linus Lüssing <linus.luessing@c0d3.blue>

Cheers
Kevin Hilman Oct. 6, 2017, 10:26 p.m. UTC | #3
Emiliano Ingrassia <ingrassia@epigenesys.com> writes:

> This patch enables the USB Host controller (USB1) and the relative USB2 PHY
> on Odroid-C1/C1+ board.
>
> Signed-off-by: Emiliano Ingrassia <ingrassia@epigenesys.com>

Appled to v4.15/dt,

Thanks,

Kevin
diff mbox

Patch

diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index e50f1a1fdbc7..9ff6ca4e20d0 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -76,3 +76,26 @@ 
 	pinctrl-0 = <&uart_ao_a_pins>;
 	pinctrl-names = "default";
 };
+
+&gpio_ao {
+	/*
+	 * WARNING: The USB Hub on the Odroid-C1/C1+ needs a reset signal
+	 * to be turned high in order to be detected by the USB Controller.
+	 * This signal should be handled by a USB specific power sequence
+	 * in order to reset the Hub when USB bus is powered down.
+	 */
+	usb-hub {
+		gpio-hog;
+		gpios = <GPIOAO_4 GPIO_ACTIVE_HIGH>;
+		output-high;
+		line-name = "usb-hub-reset";
+	};
+};
+
+&usb1_phy {
+	status = "okay";
+};
+
+&usb1 {
+	status = "okay";
+};