| Message ID | 1507555281-57845-3-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Simon Horman |
| Headers | show |
Hello! On 10/09/2017 04:21 PM, Biju Das wrote: > Enable HS-USB device for the iWave G20D-Q7 carrier board based on > RZ/G1M. > Also disable the host mode support on usb otg port by default to avoid > pin conflicts. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > --- > arch/arm/boot/dts/iwg20d-q7-common.dtsi | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > index 1c072c0..e6b50c6 100644 > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi [...] > @@ -72,7 +78,7 @@ > }; > > &pci0 { > - status = "okay"; > + status = "disabled"; I think you may just omit this prop -- you most prolly have it "disabloed" in the R8A7743's DT. > pinctrl-0 = <&usb0_pins>; > pinctrl-names = "default"; > }; MBR, Sergei
On Mon, Oct 09, 2017 at 07:18:24PM +0300, Sergei Shtylyov wrote: > Hello! > > On 10/09/2017 04:21 PM, Biju Das wrote: > > >Enable HS-USB device for the iWave G20D-Q7 carrier board based on > >RZ/G1M. > >Also disable the host mode support on usb otg port by default to avoid > >pin conflicts. > > > >Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > >--- > > arch/arm/boot/dts/iwg20d-q7-common.dtsi | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > >diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > >index 1c072c0..e6b50c6 100644 > >--- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > >+++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > [...] > >@@ -72,7 +78,7 @@ > > }; > > &pci0 { > >- status = "okay"; > >+ status = "disabled"; > > I think you may just omit this prop -- you most prolly have it > "disabloed" in the R8A7743's DT. Yes, I expect so too. > > pinctrl-0 = <&usb0_pins>; > > pinctrl-names = "default"; > > }; > > MBR, Sergei >
> -----Original Message----- > From: Simon Horman [mailto:horms@verge.net.au] > Sent: 10 October 2017 08:31 > To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Cc: Biju Das <biju.das@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; > Mark Rutland <mark.rutland@arm.com>; Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com>; Magnus Damm > <magnus.damm@gmail.com>; Chris Paterson <Chris.Paterson2@renesas.com>; > Fabrizio Castro <fabrizio.castro@bp.renesas.com>; > devicetree@vger.kernel.org; linux-renesas-soc@vger.kernel.org > Subject: Re: [PATCH 2/4] ARM: dts: iwg20d-q7: Enable HS-USB > > On Mon, Oct 09, 2017 at 07:18:24PM +0300, Sergei Shtylyov wrote: > > Hello! > > > > On 10/09/2017 04:21 PM, Biju Das wrote: > > > > >Enable HS-USB device for the iWave G20D-Q7 carrier board based on > > >RZ/G1M. > > >Also disable the host mode support on usb otg port by default to > > >avoid pin conflicts. > > > > > >Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > >Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > >--- > > > arch/arm/boot/dts/iwg20d-q7-common.dtsi | 8 +++++++- > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > >diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > >b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > >index 1c072c0..e6b50c6 100644 > > >--- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > >+++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > [...] > > >@@ -72,7 +78,7 @@ > > > }; > > > &pci0 { > > >-status = "okay"; > > >+status = "disabled"; > > > > I think you may just omit this prop -- you most prolly have it > > "disabloed" in the R8A7743's DT. > > Yes, I expect so too. Thanks for the comments. I will send v2 with dropping "status" property . > > > pinctrl-0 = <&usb0_pins>; > > > pinctrl-names = "default"; > > > }; > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi index 1c072c0..e6b50c6 100644 --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi @@ -58,6 +58,12 @@ }; }; +&hsusb { + status = "okay"; + pinctrl-0 = <&usb0_pins>; + pinctrl-names = "default"; +}; + &i2c2 { pinctrl-0 = <&i2c2_pins>; pinctrl-names = "default"; @@ -72,7 +78,7 @@ }; &pci0 { - status = "okay"; + status = "disabled"; pinctrl-0 = <&usb0_pins>; pinctrl-names = "default"; };