| Message ID | 1508144254-3526-3-git-send-email-tina.zhang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Tina Zhang (2017-10-16 09:57:34) > GEM proxy is a kind of GEM object whose backing storage cannot be changed > by host i915 driver. -ENXIO should be returned when operations are banned > from changing backing storage of this kind of GEM object. > > Signed-off-by: Tina Zhang <tina.zhang@intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
"-v1" option when sending patch series, is not needed. First revision is assumed by reader. On Mon, 2017-10-16 at 16:57 +0800, Tina Zhang wrote: > GEM proxy is a kind of GEM object whose backing storage cannot be changed > by host i915 driver. -ENXIO should be returned when operations are banned > from changing backing storage of this kind of GEM object. > > Signed-off-by: Tina Zhang <tina.zhang@intel.com> Please update the patch description and subject to just mention objects without backing storage eg. userptr and not "GEM proxy". By this patch, we've not introduced the concept of GEM proxy yet. Regards, Joonas
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 7d3116a..8f61c7f 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1713,7 +1713,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data, */ if (!obj->base.filp) { i915_gem_object_put(obj); - return -EINVAL; + return -ENXIO; } addr = vm_mmap(obj->base.filp, 0, args->size,
GEM proxy is a kind of GEM object whose backing storage cannot be changed by host i915 driver. -ENXIO should be returned when operations are banned from changing backing storage of this kind of GEM object. Signed-off-by: Tina Zhang <tina.zhang@intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)