| Message ID | d4ef5b40a6ba8b468bd22cc8e429260c42b2fb7f.1508179264.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Oct 16, 2017 at 09:04:52PM +0200, Christophe JAILLET wrote: > There is no need to shut gcc up. It should not complain. > Axe 'fbdev', it is never used in this function. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/video/fbdev/au1200fb.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c > index e531543bc707..970ce761ff89 100644 > --- a/drivers/video/fbdev/au1200fb.c > +++ b/drivers/video/fbdev/au1200fb.c > @@ -1667,10 +1667,6 @@ static int au1200fb_drv_probe(struct platform_device *dev) > printk(DRIVER_NAME ": Panel %d %s\n", panel_index, panel->name); > printk(DRIVER_NAME ": Win %d %s\n", window_index, win->name); > > - /* shut gcc up */ > - ret = 0; Heh... It looks like they were deliberately silencing the warning about the bug you fixed in patch 2/8. :P regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c index e531543bc707..970ce761ff89 100644 --- a/drivers/video/fbdev/au1200fb.c +++ b/drivers/video/fbdev/au1200fb.c @@ -1667,10 +1667,6 @@ static int au1200fb_drv_probe(struct platform_device *dev) printk(DRIVER_NAME ": Panel %d %s\n", panel_index, panel->name); printk(DRIVER_NAME ": Win %d %s\n", window_index, win->name); - /* shut gcc up */ - ret = 0; - fbdev = NULL; - for (plane = 0; plane < device_count; ++plane) { bpp = winbpp(win->w[plane].mode_winctrl1); if (win->w[plane].xres == 0) @@ -1780,7 +1776,6 @@ static int au1200fb_drv_probe(struct platform_device *dev) static int au1200fb_drv_remove(struct platform_device *dev) { struct au1200fb_platdata *pd = platform_get_drvdata(dev); - struct au1200fb_device *fbdev; struct fb_info *fbi; int plane; @@ -1789,7 +1784,6 @@ static int au1200fb_drv_remove(struct platform_device *dev) for (plane = 0; plane < device_count; ++plane) { fbi = _au1200fb_infos[plane]; - fbdev = fbi->par; /* Clean up all probe data */ unregister_framebuffer(fbi);
There is no need to shut gcc up. It should not complain. Axe 'fbdev', it is never used in this function. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/video/fbdev/au1200fb.c | 6 ------ 1 file changed, 6 deletions(-)