| Message ID | 20171023090509.4338-2-ross.lagerwall@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of > Ross Lagerwall > Sent: 23 October 2017 10:05 > To: xen-devel@lists.xen.org > Cc: Stefano Stabellini <sstabellini@kernel.org>; Wei Liu > <wei.liu2@citrix.com>; Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>; > George Dunlap <George.Dunlap@citrix.com>; Andrew Cooper > <Andrew.Cooper3@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>; Tim > (Xen.org) <tim@xen.org>; Ross Lagerwall <ross.lagerwall@citrix.com>; Jan > Beulich <jbeulich@suse.com> > Subject: [Xen-devel] [PATCH v2 1/5] xen/mm: Make > xenmem_add_to_physmap global > > Make it global in preparation to be called by a new dmop. > > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> > > --- You need to delete the above '---' otherwise this R-b will not get carried through into the commit. Paul > Reviewed-by: Paul Durrant <paul.durrant@citrix.com> > --- > xen/common/memory.c | 5 ++--- > xen/include/xen/mm.h | 3 +++ > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/xen/common/memory.c b/xen/common/memory.c > index ad987e0..c4f05c7 100644 > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -741,9 +741,8 @@ static long > memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange > _t) arg) > return rc; > } > > -static int xenmem_add_to_physmap(struct domain *d, > - struct xen_add_to_physmap *xatp, > - unsigned int start) > +int xenmem_add_to_physmap(struct domain *d, struct > xen_add_to_physmap *xatp, > + unsigned int start) > { > unsigned int done = 0; > long rc = 0; > diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h > index e813c07..0e0e511 100644 > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -579,6 +579,9 @@ int xenmem_add_to_physmap_one(struct domain > *d, unsigned int space, > union xen_add_to_physmap_batch_extra extra, > unsigned long idx, gfn_t gfn); > > +int xenmem_add_to_physmap(struct domain *d, struct > xen_add_to_physmap *xatp, > + unsigned int start); > + > /* Return 0 on success, or negative on error. */ > int __must_check guest_remove_page(struct domain *d, unsigned long > gmfn); > int __must_check steal_page(struct domain *d, struct page_info *page, > -- > 2.9.5 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel
>>> On 23.10.17 at 11:05, <ross.lagerwall@citrix.com> wrote: > Make it global in preparation to be called by a new dmop. > > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> > > --- > Reviewed-by: Paul Durrant <paul.durrant@citrix.com> Misplaced tag. I'd prefer if the function was made non-static in the patch which needs it so, but anyway Acked-by: Jan Beulich <jbeulich@suse.com> Jan
diff --git a/xen/common/memory.c b/xen/common/memory.c index ad987e0..c4f05c7 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -741,9 +741,8 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) return rc; } -static int xenmem_add_to_physmap(struct domain *d, - struct xen_add_to_physmap *xatp, - unsigned int start) +int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, + unsigned int start) { unsigned int done = 0; long rc = 0; diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index e813c07..0e0e511 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -579,6 +579,9 @@ int xenmem_add_to_physmap_one(struct domain *d, unsigned int space, union xen_add_to_physmap_batch_extra extra, unsigned long idx, gfn_t gfn); +int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, + unsigned int start); + /* Return 0 on success, or negative on error. */ int __must_check guest_remove_page(struct domain *d, unsigned long gmfn); int __must_check steal_page(struct domain *d, struct page_info *page,