| Message ID | 4a3646da88934a58525fc00141f634805ee6eb99.1508829220.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Oct 24, 2017 at 01:20:39PM +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> FWIW, Acked-by: Javi Merino <javi.merino@kernel.org> > --- > drivers/thermal/cpu_cooling.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > index 908a801..dc63aba 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -696,7 +696,7 @@ static unsigned int find_next_max(struct cpufreq_frequency_table *table, > bool first; > > if (IS_ERR_OR_NULL(policy)) { > - pr_err("%s: cpufreq policy isn't valid: %p", __func__, policy); > + pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy); > return ERR_PTR(-EINVAL); > } > > -- > 1.9.1 >
On 24-10-17, 13:20, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/thermal/cpu_cooling.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > index 908a801..dc63aba 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -696,7 +696,7 @@ static unsigned int find_next_max(struct cpufreq_frequency_table *table, > bool first; > > if (IS_ERR_OR_NULL(policy)) { > - pr_err("%s: cpufreq policy isn't valid: %p", __func__, policy); > + pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy); > return ERR_PTR(-EINVAL); > } Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index 908a801..dc63aba 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -696,7 +696,7 @@ static unsigned int find_next_max(struct cpufreq_frequency_table *table, bool first; if (IS_ERR_OR_NULL(policy)) { - pr_err("%s: cpufreq policy isn't valid: %p", __func__, policy); + pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy); return ERR_PTR(-EINVAL); }
pr_err() messages should end with a new-line to avoid other messages being concatenated. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/thermal/cpu_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)