| Message ID | 1509107832-22286-5-git-send-email-nborisov@suse.com (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
On Fri, Oct 27, 2017 at 03:37:12PM +0300, Nikolay Borisov wrote: > Since xfs_io's fiemap implementation was changed to explicitly show a whole > when a file consists only of it adjust the output of various test accordingly. > Essentially only test 1 and 10 of _test_generic_punch require changes > > Signed-off-by: Nikolay Borisov <nborisov@suse.com> > --- > tests/generic/012.out | 1 + > tests/generic/016.out | 1 + > tests/generic/021.out | 2 ++ > tests/generic/022.out | 2 ++ > tests/generic/058.out | 1 + > tests/generic/060.out | 1 + > tests/generic/061.out | 1 + > tests/generic/063.out | 1 + > tests/generic/255.out | 6 ++++++ > tests/generic/316.out | 6 ++++++ > 10 files changed, 22 insertions(+) > > diff --git a/tests/generic/012.out b/tests/generic/012.out > index ffbf8a3..8045471 100644 > --- a/tests/generic/012.out > +++ b/tests/generic/012.out > @@ -1,5 +1,6 @@ > QA output created by 012 > 1. into a hole > +0: [0..95]: hole I suspect this will break test runs with old xfs_io too (and again, I haven't confirmed yet..). Perhaps we need some kind of filter? Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 27.10.2017 15:46, Eryu Guan wrote: > On Fri, Oct 27, 2017 at 03:37:12PM +0300, Nikolay Borisov wrote: >> Since xfs_io's fiemap implementation was changed to explicitly show a whole >> when a file consists only of it adjust the output of various test accordingly. >> Essentially only test 1 and 10 of _test_generic_punch require changes >> >> Signed-off-by: Nikolay Borisov <nborisov@suse.com> >> --- >> tests/generic/012.out | 1 + >> tests/generic/016.out | 1 + >> tests/generic/021.out | 2 ++ >> tests/generic/022.out | 2 ++ >> tests/generic/058.out | 1 + >> tests/generic/060.out | 1 + >> tests/generic/061.out | 1 + >> tests/generic/063.out | 1 + >> tests/generic/255.out | 6 ++++++ >> tests/generic/316.out | 6 ++++++ >> 10 files changed, 22 insertions(+) >> >> diff --git a/tests/generic/012.out b/tests/generic/012.out >> index ffbf8a3..8045471 100644 >> --- a/tests/generic/012.out >> +++ b/tests/generic/012.out >> @@ -1,5 +1,6 @@ >> QA output created by 012 >> 1. into a hole >> +0: [0..95]: hole > > I suspect this will break test runs with old xfs_io too (and again, I > haven't confirmed yet..). Perhaps we need some kind of filter? You are right it will indeed break with old xfs_io so some solution need to be created. At this time I'm more interested to see if people will accept the fiemap code and if there is agreement I will focus on creating such a filter. > > Thanks, > Eryu > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/generic/012.out b/tests/generic/012.out index ffbf8a3..8045471 100644 --- a/tests/generic/012.out +++ b/tests/generic/012.out @@ -1,5 +1,6 @@ QA output created by 012 1. into a hole +0: [0..95]: hole f4f35d60b3cc18aaa6d8d92f0cd3708a 2. into allocated space 0: [0..95]: extent diff --git a/tests/generic/016.out b/tests/generic/016.out index c45a44a..1371ce7 100644 --- a/tests/generic/016.out +++ b/tests/generic/016.out @@ -1,5 +1,6 @@ QA output created by 016 1. into a hole +0: [0..95]: hole f4f35d60b3cc18aaa6d8d92f0cd3708a 2. into allocated space 0: [0..95]: extent diff --git a/tests/generic/021.out b/tests/generic/021.out index 1137741..791b78a 100644 --- a/tests/generic/021.out +++ b/tests/generic/021.out @@ -1,5 +1,6 @@ QA output created by 021 1. into a hole +0: [0..95]: hole f4f35d60b3cc18aaa6d8d92f0cd3708a 2. into allocated space 0: [0..95]: extent @@ -34,6 +35,7 @@ f4f35d60b3cc18aaa6d8d92f0cd3708a 1: [64..95]: hole d8f51c20223dbce5c7c90db87bc221b0 10. hole -> data -> hole +0: [0..63]: hole bb7df04e1b0a2570657527a7e108ae23 11. data -> hole -> data 0: [0..63]: extent diff --git a/tests/generic/022.out b/tests/generic/022.out index fbffa59..6dbc192 100644 --- a/tests/generic/022.out +++ b/tests/generic/022.out @@ -1,5 +1,6 @@ QA output created by 022 1. into a hole +0: [0..95]: hole f4f35d60b3cc18aaa6d8d92f0cd3708a 2. into allocated space 0: [0..95]: extent @@ -34,6 +35,7 @@ f4f35d60b3cc18aaa6d8d92f0cd3708a 1: [64..95]: hole d8f51c20223dbce5c7c90db87bc221b0 10. hole -> data -> hole +0: [0..63]: hole bb7df04e1b0a2570657527a7e108ae23 11. data -> hole -> data 0: [0..63]: extent diff --git a/tests/generic/058.out b/tests/generic/058.out index b15308d..3bbc2a4 100644 --- a/tests/generic/058.out +++ b/tests/generic/058.out @@ -1,5 +1,6 @@ QA output created by 058 1. into a hole +0: [0..55]: hole cf845a781c107ec1346e849c9dd1b7e8 2. into allocated space 0: [0..7]: extent diff --git a/tests/generic/060.out b/tests/generic/060.out index 909b578..210af74 100644 --- a/tests/generic/060.out +++ b/tests/generic/060.out @@ -1,5 +1,6 @@ QA output created by 060 1. into a hole +0: [0..55]: hole cf845a781c107ec1346e849c9dd1b7e8 2. into allocated space 0: [0..7]: extent diff --git a/tests/generic/061.out b/tests/generic/061.out index 78d6c6d..6d95680 100644 --- a/tests/generic/061.out +++ b/tests/generic/061.out @@ -1,5 +1,6 @@ QA output created by 061 1. into a hole +0: [0..55]: hole cf845a781c107ec1346e849c9dd1b7e8 2. into allocated space 0: [0..7]: extent diff --git a/tests/generic/063.out b/tests/generic/063.out index d828ff6..10db43f 100644 --- a/tests/generic/063.out +++ b/tests/generic/063.out @@ -1,5 +1,6 @@ QA output created by 063 1. into a hole +0: [0..55]: hole cf845a781c107ec1346e849c9dd1b7e8 2. into allocated space 0: [0..7]: extent diff --git a/tests/generic/255.out b/tests/generic/255.out index 217ef3e..441fde8 100644 --- a/tests/generic/255.out +++ b/tests/generic/255.out @@ -1,5 +1,6 @@ QA output created by 255 1. into a hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 2. into allocated space 0: [0..7]: extent @@ -42,6 +43,7 @@ daa100df6e6711906b61c9ab5aa16032 3: [32..39]: hole cc63069677939f69a6e8f68cae6a6dac 10. hole -> data -> hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 11. data -> hole -> data 0: [0..7]: extent @@ -79,6 +81,7 @@ eecb7aa303d121835de05028751d301c 0000400 cdcd cdcd cdcd cdcd cdcd cdcd cdcd cdcd * 1. into a hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 2. into allocated space 0: [0..7]: extent @@ -121,6 +124,7 @@ daa100df6e6711906b61c9ab5aa16032 3: [32..39]: hole cc63069677939f69a6e8f68cae6a6dac 10. hole -> data -> hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 11. data -> hole -> data 0: [0..7]: extent @@ -158,6 +162,7 @@ eecb7aa303d121835de05028751d301c 0000400 cdcd cdcd cdcd cdcd cdcd cdcd cdcd cdcd * 1. into a hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 2. into allocated space 0: [0..7]: extent @@ -240,6 +245,7 @@ eecb7aa303d121835de05028751d301c 0000400 cdcd cdcd cdcd cdcd cdcd cdcd cdcd cdcd * 1. into a hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 2. into allocated space 0: [0..7]: extent diff --git a/tests/generic/316.out b/tests/generic/316.out index 383f0d1..5506198 100644 --- a/tests/generic/316.out +++ b/tests/generic/316.out @@ -1,5 +1,6 @@ QA output created by 316 1. into a hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 2. into allocated space 0: [0..7]: extent @@ -16,6 +17,7 @@ cc63069677939f69a6e8f68cae6a6dac 1: [8..39]: hole 1b3779878366498b28c702ef88c4a773 10. hole -> data -> hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 11. data -> hole -> data 0: [0..7]: extent @@ -43,6 +45,7 @@ eecb7aa303d121835de05028751d301c 0000400 cdcd cdcd cdcd cdcd cdcd cdcd cdcd cdcd * 1. into a hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 2. into allocated space 0: [0..7]: extent @@ -59,6 +62,7 @@ cc63069677939f69a6e8f68cae6a6dac 1: [8..39]: hole 1b3779878366498b28c702ef88c4a773 10. hole -> data -> hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 11. data -> hole -> data 0: [0..7]: extent @@ -86,6 +90,7 @@ eecb7aa303d121835de05028751d301c 0000400 cdcd cdcd cdcd cdcd cdcd cdcd cdcd cdcd * 1. into a hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 2. into allocated space 0: [0..7]: extent @@ -133,6 +138,7 @@ eecb7aa303d121835de05028751d301c 0000400 cdcd cdcd cdcd cdcd cdcd cdcd cdcd cdcd * 1. into a hole +0: [0..39]: hole daa100df6e6711906b61c9ab5aa16032 2. into allocated space 0: [0..7]: extent
Since xfs_io's fiemap implementation was changed to explicitly show a whole when a file consists only of it adjust the output of various test accordingly. Essentially only test 1 and 10 of _test_generic_punch require changes Signed-off-by: Nikolay Borisov <nborisov@suse.com> --- tests/generic/012.out | 1 + tests/generic/016.out | 1 + tests/generic/021.out | 2 ++ tests/generic/022.out | 2 ++ tests/generic/058.out | 1 + tests/generic/060.out | 1 + tests/generic/061.out | 1 + tests/generic/063.out | 1 + tests/generic/255.out | 6 ++++++ tests/generic/316.out | 6 ++++++ 10 files changed, 22 insertions(+)